From: Sascha Hauer <s.hauer@pengutronix.de>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 07/12] commands/umount: Return real error code if "umount" fail
Date: Wed, 23 Apr 2014 11:54:58 +0200 [thread overview]
Message-ID: <20140423095458.GL5858@pengutronix.de> (raw)
In-Reply-To: <1397290265-21273-7-git-send-email-shc_work@mail.ru>
On Sat, Apr 12, 2014 at 12:11:00PM +0400, Alexander Shiyan wrote:
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
> commands/umount.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/commands/umount.c b/commands/umount.c
> index e6de1bc..8dcf7f0 100644
> --- a/commands/umount.c
> +++ b/commands/umount.c
> @@ -28,11 +28,10 @@ static int do_umount(int argc, char *argv[])
> if (argc != 2)
> return COMMAND_ERROR_USAGE;
>
> - if ((ret = umount(argv[1]))) {
> + if ((ret = umount(argv[1])))
> perror("umount");
> - return 1;
> - }
Here perror() also should be removed.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2014-04-23 9:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-12 8:10 [PATCH 01/12] scripts: imx-image: Fix resource leak Alexander Shiyan
2014-04-12 8:10 ` [PATCH 02/12] gui: " Alexander Shiyan
2014-04-12 8:10 ` [PATCH 03/12] lzo: Remove unused variable Alexander Shiyan
2014-04-12 8:10 ` [PATCH 04/12] ubifs: " Alexander Shiyan
2014-04-12 8:10 ` [PATCH 05/12] commands/mount: Return real error code if "mount" fail Alexander Shiyan
2014-04-23 9:47 ` Sascha Hauer
2014-04-12 8:10 ` [PATCH 06/12] commands/uimage: Fix error printing Alexander Shiyan
2014-04-12 8:11 ` [PATCH 07/12] commands/umount: Return real error code if "umount" fail Alexander Shiyan
2014-04-23 9:54 ` Sascha Hauer [this message]
2014-04-12 8:11 ` [PATCH 08/12] commands/usbserial: Remove unused variable Alexander Shiyan
2014-04-12 8:11 ` [PATCH 09/12] ata: pata-imx: " Alexander Shiyan
2014-04-12 8:11 ` [PATCH 10/12] imx_keypad: Fix error handling Alexander Shiyan
2014-04-23 9:54 ` Sascha Hauer
2014-04-12 8:11 ` [PATCH 11/12] mtd: partition: Remove unused variable Alexander Shiyan
2014-04-12 8:11 ` [PATCH 12/12] mtd: nand: bbt: " Alexander Shiyan
2014-04-23 9:56 ` [PATCH 01/12] scripts: imx-image: Fix resource leak Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140423095458.GL5858@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=shc_work@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox