mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH 1/1 - Corrected] Fix bug in export 64 bit unsigned environment variable.
@ 2014-04-10 20:32 Michael D. Burkey
  2014-04-23 10:37 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Michael D. Burkey @ 2014-04-10 20:32 UTC (permalink / raw)
  To: barebox

The first time I sent this I apparently typed a character into the
wrong window before I sent it and didn't notice it.

-------------------------------------------------------------------------

--- a/common/env.c
+++ b/common/env.c
@@ -258,7 +258,7 @@

 void export_env_ull(const char *name, unsigned long long val)
 {
-       char *valstr = asprintf("%lld", val);
+       char *valstr = asprintf("%llu", val);

        setenv(name, valstr);
        export(name);

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/1 - Corrected] Fix bug in export 64 bit unsigned environment variable.
  2014-04-10 20:32 [PATCH 1/1 - Corrected] Fix bug in export 64 bit unsigned environment variable Michael D. Burkey
@ 2014-04-23 10:37 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2014-04-23 10:37 UTC (permalink / raw)
  To: Michael D. Burkey; +Cc: barebox

Hi Michael,

On Thu, Apr 10, 2014 at 04:32:38PM -0400, Michael D. Burkey wrote:
> The first time I sent this I apparently typed a character into the
> wrong window before I sent it and didn't notice it.

The patch is ok. Please resend this with a propert signed-off-by line so
I can apply it.

Sascha

> 
> -------------------------------------------------------------------------
> 
> --- a/common/env.c
> +++ b/common/env.c
> @@ -258,7 +258,7 @@
> 
>  void export_env_ull(const char *name, unsigned long long val)
>  {
> -       char *valstr = asprintf("%lld", val);
> +       char *valstr = asprintf("%llu", val);
> 
>         setenv(name, valstr);
>         export(name);
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-04-23 10:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-10 20:32 [PATCH 1/1 - Corrected] Fix bug in export 64 bit unsigned environment variable Michael D. Burkey
2014-04-23 10:37 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox