From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-ee0-x230.google.com ([2a00:1450:4013:c00::230]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Weqed-0005qo-Ne for barebox@lists.infradead.org; Mon, 28 Apr 2014 18:51:52 +0000 Received: by mail-ee0-f48.google.com with SMTP id b57so5096848eek.7 for ; Mon, 28 Apr 2014 11:51:29 -0700 (PDT) Date: Mon, 28 Apr 2014 20:51:21 +0200 From: Alexander Aring Message-ID: <20140428185119.GA11686@omega> References: <1398673121-6075-1-git-send-email-s.hauer@pengutronix.de> <1398673121-6075-2-git-send-email-s.hauer@pengutronix.de> <20140428163015.GB19883@omega> <20140428184702.GW5858@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20140428184702.GW5858@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 1/2] Add initial regulator support To: Sascha Hauer Cc: barebox@lists.infradead.org Hi, On Mon, Apr 28, 2014 at 08:47:02PM +0200, Sascha Hauer wrote: > > I think both functions should return 0 without a valid gpio instead. > Anyway, there's something wrong here. > maybe checking on this at probe time, at the beginning or can this gpio changed at runtime? Maybe you don't need this here because probe will already failed with a invalid gpio. - Alex _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox