From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WhDCk-0002jW-PB for barebox@lists.infradead.org; Mon, 05 May 2014 07:20:51 +0000 Date: Mon, 5 May 2014 09:20:29 +0200 From: Sascha Hauer Message-ID: <20140505072029.GR5858@pengutronix.de> References: <1398846723-10241-1-git-send-email-y> <5360b518.c62a980a.05b6.526c@mx.google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5360b518.c62a980a.05b6.526c@mx.google.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 1/3] tftp: add timeframe when remote server is retransmitting To: chf.fritz@googlemail.com Cc: barebox@lists.infradead.org Hi Christoph, On Wed, Apr 30, 2014 at 10:32:01AM +0200, chf.fritz@googlemail.com wrote: > From: Christoph Fritz > > If there's packet loss and the remote server needs to retransmit, > there is falsely no timeframe left because TIMEOUT (server wait time) > and TFTP_TIMEOUT (abort timer) are the same. > > This patch increases TFTP_TIMEOUT. > > See RFC2349 for more info: http://tools.ietf.org/html/rfc2349 > > Signed-off-by: Christoph Fritz Applied, thanks Sascha > --- > fs/tftp.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/fs/tftp.c b/fs/tftp.c > index 9cad18f..b1a213e 100644 > --- a/fs/tftp.c > +++ b/fs/tftp.c > @@ -33,14 +33,16 @@ > #include > #include > > -#define TFTP_PORT 69 /* Well known TFTP port # */ > -#define TIMEOUT 5 /* Seconds to timeout for a lost pkt */ > +#define TFTP_PORT 69 /* Well known TFTP port number */ > + > +/* Seconds to wait before remote server is allowed to resend a lost packet */ > +#define TIMEOUT 5 > > /* After this time without a response from the server we will resend a packet */ > #define TFTP_RESEND_TIMEOUT SECOND > > /* After this time without progress we will bail out */ > -#define TFTP_TIMEOUT (TIMEOUT * SECOND) > +#define TFTP_TIMEOUT ((TIMEOUT * 3) * SECOND) > > /* > * TFTP operations. > -- > 1.7.10.4 > > > _______________________________________________ > barebox mailing list > barebox@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/barebox > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox