mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Wadim Egorov <w.egorov@phytec.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v2 4/4] phycore-am335x: Added bbu nand xloadslots handler
Date: Thu, 15 May 2014 14:59:57 +0200	[thread overview]
Message-ID: <20140515125957.GM5858@pengutronix.de> (raw)
In-Reply-To: <1400146868-17820-2-git-send-email-w.egorov@phytec.de>

On Thu, May 15, 2014 at 11:41:08AM +0200, Wadim Egorov wrote:
> Added bbu nand xloadslots handler to phycore-am335x.
> 
> Signed-off-by: Wadim Egorov <w.egorov@phytec.de>
> ---
> v2:
>   - changed method to pass device files
> ---
>  arch/arm/boards/phytec-phycore-am335x/board.c |    9 +++++++++
>  1 files changed, 9 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/boards/phytec-phycore-am335x/board.c b/arch/arm/boards/phytec-phycore-am335x/board.c
> index 59de42b..76782d4 100644
> --- a/arch/arm/boards/phytec-phycore-am335x/board.c
> +++ b/arch/arm/boards/phytec-phycore-am335x/board.c
> @@ -48,6 +48,13 @@ static struct omap_barebox_part pcm051_barebox_part = {
>  	.nor_size = SZ_512K,
>  };
>  
> +char *xloadslots[] = {
> +	"/dev/nand0.xload.bb",
> +	"/dev/nand0.xload_backup1.bb",
> +	"/dev/nand0.xload_backup2.bb",
> +	"/dev/nand0.xload_backup3.bb"
> +};
> +
>  static int pcm051_devices_init(void)
>  {
>  	if (!of_machine_is_compatible("phytec,pcm051"))
> @@ -69,6 +76,8 @@ static int pcm051_devices_init(void)
>  	armlinux_set_architecture(MACH_TYPE_PCM051);
>  
>  	am33xx_bbu_spi_nor_mlo_register_handler("MLO.spi", "/dev/m25p0.xload");
> +	am33xx_bbu_nand_xloadslots_register_handler("xloadslots",
> +		xloadslots, ARRAY_SIZE(xloadslots));

Can you use a name with containing 'nand' in it? When one reads
'xloadslots' he probably hasn't got a clue which image is updated.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2014-05-15 13:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-15  9:41 [PATCH v2 3/4] ARM: omap: barebox update " Wadim Egorov
2014-05-15  9:41 ` [PATCH v2 4/4] phycore-am335x: Added bbu " Wadim Egorov
2014-05-15  9:48   ` Alexander Aring
2014-05-15  9:55     ` Alexander Aring
2014-05-15 12:59   ` Sascha Hauer [this message]
2014-05-15 12:58 ` [PATCH v2 3/4] ARM: omap: barebox update " Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140515125957.GM5858@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=w.egorov@phytec.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox