mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Fabio Estevam <fabio.estevam@freescale.com>
Cc: barebox@lists.infradead.org, eric.nelson@boundarydevices.com
Subject: Re: [PATCH] serial: imx: Fix buggy transmissions when baudrate mismatches
Date: Thu, 15 May 2014 23:21:25 +0200	[thread overview]
Message-ID: <20140515212125.GO5858@pengutronix.de> (raw)
In-Reply-To: <1400177676-2870-1-git-send-email-fabio.estevam@freescale.com>

Hi Fabio,

On Thu, May 15, 2014 at 03:14:36PM -0300, Fabio Estevam wrote:
> Bit 7 of UCR3 is described in the i.MX reference manuals (with the exception
> of i.MX1) as follows:
> 
> ADNIMP: Autobaud Detection Not Improved-. Disables new features of
> 	autobaud detection (See Baud Rate Automatic Detection
> 	Protocol, for more details).
> 
> 	0 Autobaud detection new features selected
> 	1 Keep old autobaud detection mechanism
> 
> The "new features" mechanism occasionally causes the receiver to get out of sync 
> and continuously produces received characters of '0xff'.
> 
> In order to reproduce the problem:
> 
> $ cs0.baudrate=19200
> - Change the terminal baudrate to 19200
> - Type in the console and it should look good
> - Change the terminal baudrate back to 115200
> - Type 'b' in the console, then a stream of '0xff' is transmitted in loop
> 
> Setting the ADNIMP bit avoids the transmission of '0xff' in loop.
> 
> Also rename the bit definition as per the reference manual.
> 
> Tested on mx6q.
> 
> Based on a patch from Eric Nelson for U-boot.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> As the 0xff character is not seen in the console, an easy way to 'see' it is 
> doing like this in order to easily demonstrate the bug:
> 
> --- a/drivers/serial/serial_imx.c
> +++ b/drivers/serial/serial_imx.c
> @@ -258,7 +258,8 @@ static int imx_serial_getc(struct console_device *cdev)
>         while (readl(priv->regs + priv->devtype->uts) & UTS_RXEMPTY);
>  
>         ch = readl(priv->regs + URXD0);
> -
> +       if (ch >= 0x80)
> +               ch = '?';

This is not part of the fix, right?

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2014-05-15 21:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-15 18:14 Fabio Estevam
2014-05-15 21:21 ` Sascha Hauer [this message]
2014-05-15 22:05   ` Fabio Estevam
2014-05-28 19:57     ` Fabio Estevam
2014-06-02  7:22       ` Sascha Hauer
2014-06-02 10:59         ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140515212125.GO5858@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=eric.nelson@boundarydevices.com \
    --cc=fabio.estevam@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox