mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Alexander Aring <alex.aring@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 4/6] oftree: remove dump support
Date: Tue, 20 May 2014 10:01:03 +0200	[thread overview]
Message-ID: <20140520080101.GA1334@omega> (raw)
In-Reply-To: <1400533184-668-5-git-send-email-s.hauer@pengutronix.de>

Hi Sascha,

On Mon, May 19, 2014 at 10:59:42PM +0200, Sascha Hauer wrote:
> This can now be done with the of_dump command.
> 
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
>  commands/Kconfig  |  2 --
>  commands/oftree.c | 42 +++---------------------------------------
>  2 files changed, 3 insertions(+), 41 deletions(-)
> 
> diff --git a/commands/Kconfig b/commands/Kconfig
> index 381f3fd..6043cb6 100644
> --- a/commands/Kconfig
> +++ b/commands/Kconfig
> @@ -1944,8 +1944,6 @@ config CMD_OFTREE
>  		  -l		Load DTB to internal device tree
>  		  -p		probe devices from stored device tree
>  		  -f		free stored device tree
> -		  -d		dump device tree from DTB or the parsed tree if no DTB is given
> -		  -n NODE	specify root device NODE to dump for -d
>  
>  config CMD_TIME
>  	bool "time"
> diff --git a/commands/oftree.c b/commands/oftree.c
> index 16648d6..db31d59 100644
> --- a/commands/oftree.c
> +++ b/commands/oftree.c
> @@ -46,8 +46,6 @@ static int do_oftree(int argc, char *argv[])
>  	int size;
>  	int opt;
>  	char *file = NULL;
> -	const char *node = "/";
> -	int dump = 0;
>  	int probe = 0;
>  	int load = 0;
>  	int save = 0;
> @@ -55,14 +53,11 @@ static int do_oftree(int argc, char *argv[])
>  	int ret;
>  	struct device_node *n, *root;
>  
> -	while ((opt = getopt(argc, argv, "dpfn:ls")) > 0) {
> +	while ((opt = getopt(argc, argv, "pfl:s:")) > 0) {

Are you sure this optstring conversion is correct? Before there was
no optargs for -l and -s.

- Alex

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2014-05-20  8:01 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-19 20:59 [PATCH] devicetree command changes Sascha Hauer
2014-05-19 20:59 ` [PATCH 1/6] complete: Fix completion after options Sascha Hauer
2014-05-19 20:59 ` [PATCH 2/6] complete: Add devicetree completion Sascha Hauer
2014-05-19 20:59 ` [PATCH 3/6] commands: add of_dump command Sascha Hauer
2014-05-21 13:17   ` Holger Schurig
2014-05-22  6:10     ` Sascha Hauer
2014-05-19 20:59 ` [PATCH 4/6] oftree: remove dump support Sascha Hauer
2014-05-20  8:01   ` Alexander Aring [this message]
2014-05-20  8:03     ` Alexander Aring
2014-05-20  9:08       ` Sascha Hauer
2014-05-19 20:59 ` [PATCH 5/6] of: Drop devicetree merge support Sascha Hauer
2014-05-20 15:08   ` Sebastian Hesselbarth
2014-05-21  6:13     ` Sascha Hauer
2014-05-21  6:35     ` Esben Haabendal
2014-05-21 12:39       ` Sascha Hauer
2014-05-21 13:24   ` Holger Schurig
2014-05-19 20:59 ` [PATCH 6/6] oftree command: make devicetree file optargs to -l/-s Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140520080101.GA1334@omega \
    --to=alex.aring@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox