From: Sascha Hauer <s.hauer@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: "barebox@lists.infradead.org" <barebox@lists.infradead.org>
Subject: Re: [PATCH] [RFC] [WIP] commands: add tree view capable lsusb
Date: Mon, 2 Jun 2014 09:24:50 +0200 [thread overview]
Message-ID: <20140602072450.GW15686@pengutronix.de> (raw)
In-Reply-To: <20140521181123.22fa7c295a12523e27d6964b@gmail.com>
On Wed, May 21, 2014 at 06:11:23PM +0400, Antony Pavlov wrote:
> On Wed, 21 May 2014 15:20:21 +0200
> Holger Schurig <holgerschurig@gmail.com> wrote:
>
> > Nice, I would just remove the extra empty lines. Linux' "lsusb -t" for
>
> Good idea! I'll take a look on Linux' lsusb too.
>
> > example produces this:
> >
> > holger@desktop:~$ lsusb -t
> > /: Bus 02.Port 1: Dev 1, Class=root_hub, Driver=ehci-pci/2p, 480M
> > |__ Port 1: Dev 2, If 0, Class=hub, Driver=hub/8p, 480M
> > |__ Port 1: Dev 27, If 0, Class=HID, Driver=usbhid, 1.5M
> > |__ Port 2: Dev 4, If 0, Class=HID, Driver=usbhid, 1.5M
> > |__ Port 6: Dev 126, If 0, Class=hub, Driver=hub/2p, 480M
> > /: Bus 01.Port 1: Dev 1, Class=root_hub, Driver=ehci-pci/2p, 480M
> > |__ Port 1: Dev 2, If 0, Class=hub, Driver=hub/6p, 480M
> >
> > Also please add an entry into commands/Kconfig:
>
> I'll separate lsusb code into independent lsusb.c file.
>
> > And put it into the
> > info group, lsusb just shows something, it doesn't manipulate any
> > hardware.
>
> Not exactly so. It invokes usb_rescan(0).
You could drop the usb_rescan(). Would that be too confusing?
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2014-06-02 7:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-21 8:54 Antony Pavlov
2014-05-21 13:20 ` Holger Schurig
2014-05-21 14:11 ` Antony Pavlov
2014-06-02 7:24 ` Sascha Hauer [this message]
2014-06-02 7:59 ` Holger Schurig
2014-06-02 8:31 ` Sascha Hauer
2014-06-02 10:20 ` Antony Pavlov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140602072450.GW15686@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox