Fix Compiler warnings

Fix Compiler warnings

[Sascha Hauer]

The following are fixes for various compiler warnings

Sascha

----------------------------------------------------------------
Sascha Hauer (9):
      fix format specifiers
      ARM: MXS: Remove unused variables
      ARM: friendlyarm_mini2440: refresh defconfig
      mips: dlink-dir-320: refresh defconfig
      mips: ar9331: Add missing #address-cells/#size-cells properties
      PPC: FSL DDR: Fix compiler warning
      commands: drvinfo: Make locally used function static
      gui: IMAGE_RENDERER does not depend on VIDEO
      mips: Add builtin dtb to dtb-y

 arch/arm/boards/chumby_falconwing/falconwing.c     |  2 +-
 arch/arm/boards/crystalfontz-cfa10036/cfa10036.c   |  2 +-
 arch/arm/boards/imx233-olinuxino/imx23-olinuxino.c |  3 +--
 arch/arm/configs/friendlyarm_mini2440_defconfig    | 31 ++++++++++------------
 arch/mips/configs/dlink-dir-320_defconfig          |  4 ---
 arch/mips/dts/Makefile                             |  6 +++--
 arch/mips/dts/ar9331.dtsi                          |  2 ++
 arch/ppc/include/asm/fsl_ddr_sdram.h               |  2 +-
 commands/drvinfo.c                                 |  2 +-
 common/bootm.c                                     |  4 +--
 common/uimage.c                                    |  4 ++-
 drivers/eeprom/at25.c                              |  4 +--
 lib/gui/Kconfig                                    |  1 -
 13 files changed, 32 insertions(+), 35 deletions(-)

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 1/9] fix format specifiers

[Sascha Hauer]

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 common/bootm.c        | 4 ++--
 common/uimage.c       | 4 +++-
 drivers/eeprom/at25.c | 4 ++--
 3 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/common/bootm.c b/common/bootm.c
index 871959c..71390cb 100644
--- a/common/bootm.c
+++ b/common/bootm.c
@@ -312,7 +312,7 @@ static int bootm_open_oftree(struct image_data *data, const char *oftree, int nu
 static void bootm_print_info(struct image_data *data)
 {
 	if (data->os_res)
-		printf("OS image is at 0x%08x-0x%08x\n",
+		printf("OS image is at " PRINTF_CONVERSION_RESOURCE "-" PRINTF_CONVERSION_RESOURCE "\n",
 				data->os_res->start,
 				data->os_res->end);
 	else
@@ -329,7 +329,7 @@ static void bootm_print_info(struct image_data *data)
 			printf(", multifile image %d", data->initrd_num);
 		printf("\n");
 		if (data->initrd_res)
-			printf("initrd is at 0x%08x-0x%08x\n",
+			printf("initrd is at " PRINTF_CONVERSION_RESOURCE "-" PRINTF_CONVERSION_RESOURCE "\n",
 				data->initrd_res->start,
 				data->initrd_res->end);
 		else
diff --git a/common/uimage.c b/common/uimage.c
index 243dfb0..4ef0968 100644
--- a/common/uimage.c
+++ b/common/uimage.c
@@ -353,7 +353,9 @@ static int uimage_sdram_flush(void *buf, unsigned int len)
 		uimage_resource = request_sdram_region("uimage",
 				start, size);
 		if (!uimage_resource) {
-			printf("unable to request SDRAM 0x%08x-0x%08x\n",
+			printf("unable to request SDRAM "
+					PRINTF_CONVERSION_RESOURCE "-"
+					PRINTF_CONVERSION_RESOURCE "\n",
 				start, start + size - 1);
 			return -ENOMEM;
 		}
diff --git a/drivers/eeprom/at25.c b/drivers/eeprom/at25.c
index 266f261..3e75b56 100644
--- a/drivers/eeprom/at25.c
+++ b/drivers/eeprom/at25.c
@@ -117,8 +117,8 @@ static ssize_t at25_ee_read(struct cdev *cdev,
 	 */
 	status = spi_sync(at25->spi, &m);
 	dev_dbg(at25->cdev.dev,
-		"read %d bytes at %llu --> %d\n",
-		count, offset, (int) status);
+		"read %zd bytes at %llu --> %zd\n",
+		count, offset, status);
 
 	return status ? status : count;
 }
-- 
2.0.0.rc2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 2/9] ARM: MXS: Remove unused variables

[Sascha Hauer]

Fixes:

arch/arm/boards/crystalfontz-cfa10036/cfa10036.c: In function 'cfa10036_devices_init':
arch/arm/boards/crystalfontz-cfa10036/cfa10036.c:119:9: warning: unused variable 'ret' [-Wunused-variable]
arch/arm/boards/chumby_falconwing/falconwing.c: In function 'falconwing_devices_init':
arch/arm/boards/chumby_falconwing/falconwing.c:287:9: warning: unused variable 'rc' [-Wunused-variable]
arch/arm/boards/imx233-olinuxino/imx23-olinuxino.c: In function 'imx23_olinuxino_devices_init':
arch/arm/boards/imx233-olinuxino/imx23-olinuxino.c:118:9: warning: unused variable 'rc' [-Wunused-variable]

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 arch/arm/boards/chumby_falconwing/falconwing.c     | 2 +-
 arch/arm/boards/crystalfontz-cfa10036/cfa10036.c   | 2 +-
 arch/arm/boards/imx233-olinuxino/imx23-olinuxino.c | 3 +--
 3 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boards/chumby_falconwing/falconwing.c b/arch/arm/boards/chumby_falconwing/falconwing.c
index 669de95..77581f6 100644
--- a/arch/arm/boards/chumby_falconwing/falconwing.c
+++ b/arch/arm/boards/chumby_falconwing/falconwing.c
@@ -284,7 +284,7 @@ static void falconwing_init_usb(void)
 
 static int falconwing_devices_init(void)
 {
-	int i, rc;
+	int i;
 
 	/* initizalize gpios */
 	for (i = 0; i < ARRAY_SIZE(pad_setup); i++)
diff --git a/arch/arm/boards/crystalfontz-cfa10036/cfa10036.c b/arch/arm/boards/crystalfontz-cfa10036/cfa10036.c
index 3374338..e6ebe82 100644
--- a/arch/arm/boards/crystalfontz-cfa10036/cfa10036.c
+++ b/arch/arm/boards/crystalfontz-cfa10036/cfa10036.c
@@ -116,7 +116,7 @@ mem_initcall(cfa10036_mem_init);
 
 static int cfa10036_devices_init(void)
 {
-	int i, ret;
+	int i;
 
 	/* initizalize muxing */
 	for (i = 0; i < ARRAY_SIZE(cfa10036_pads); i++)
diff --git a/arch/arm/boards/imx233-olinuxino/imx23-olinuxino.c b/arch/arm/boards/imx233-olinuxino/imx23-olinuxino.c
index 3d46604..6346c25 100644
--- a/arch/arm/boards/imx233-olinuxino/imx23-olinuxino.c
+++ b/arch/arm/boards/imx233-olinuxino/imx23-olinuxino.c
@@ -115,8 +115,7 @@ static void olinuxino_init_usb(void)
 
 static int imx23_olinuxino_devices_init(void)
 {
-	int i, rc;
-
+	int i;
 
 	/* initizalize gpios */
 	for (i = 0; i < ARRAY_SIZE(pad_setup); i++)
-- 
2.0.0.rc2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 3/9] ARM: friendlyarm_mini2440: refresh defconfig

[Sascha Hauer]

Fixes:

arch/arm/configs/friendlyarm_mini2440_defconfig:38:warning: override: reassigning to symbol CMD_TFTP
arch/arm/configs/friendlyarm_mini2440_defconfig:46:warning: override: reassigning to symbol FS_TFTP

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 arch/arm/configs/friendlyarm_mini2440_defconfig | 31 +++++++++++--------------
 1 file changed, 14 insertions(+), 17 deletions(-)

diff --git a/arch/arm/configs/friendlyarm_mini2440_defconfig b/arch/arm/configs/friendlyarm_mini2440_defconfig
index acd5e42..6cbafef 100644
--- a/arch/arm/configs/friendlyarm_mini2440_defconfig
+++ b/arch/arm/configs/friendlyarm_mini2440_defconfig
@@ -7,36 +7,33 @@ CONFIG_ARM_OPTIMZED_STRING_FUNCTIONS=y
 CONFIG_TEXT_BASE=0x33e00000
 CONFIG_BROKEN=y
 CONFIG_PROMPT="mini2440:"
-CONFIG_LONGHELP=y
 CONFIG_GLOB=y
-CONFIG_HUSH_GETOPT=y
 CONFIG_CMDLINE_EDITING=y
 CONFIG_AUTO_COMPLETE=y
 CONFIG_DEFAULT_ENVIRONMENT_PATH="arch/arm/boards/friendlyarm-mini2440/env"
 CONFIG_DEBUG_INFO=y
-CONFIG_CMD_EDIT=y
-CONFIG_CMD_SLEEP=y
-CONFIG_CMD_SAVEENV=y
-CONFIG_CMD_LOADENV=y
+CONFIG_LONGHELP=y
+CONFIG_CMD_MEMINFO=y
+CONFIG_CMD_GO=y
+CONFIG_CMD_RESET=y
+CONFIG_CMD_PARTITION=y
 CONFIG_CMD_EXPORT=y
-CONFIG_CMD_PRINTENV=y
-CONFIG_CMD_READLINE=y
 CONFIG_CMD_GLOBAL=y
+CONFIG_CMD_LOADENV=y
+CONFIG_CMD_PRINTENV=y
+CONFIG_CMD_SAVEENV=y
+CONFIG_CMD_SLEEP=y
+CONFIG_CMD_DHCP=y
+CONFIG_CMD_PING=y
 CONFIG_CMD_TFTP=y
-CONFIG_CMD_MEMINFO=y
+CONFIG_CMD_EDIT=y
+CONFIG_CMD_READLINE=y
+CONFIG_CMD_TIMEOUT=y
 CONFIG_CMD_CRC=y
 CONFIG_CMD_CRC_CMP=y
 CONFIG_CMD_FLASH=y
-CONFIG_CMD_RESET=y
-CONFIG_CMD_GO=y
-CONFIG_CMD_TIMEOUT=y
-CONFIG_CMD_PARTITION=y
 CONFIG_CMD_GPIO=y
 CONFIG_NET=y
-CONFIG_CMD_DHCP=y
-CONFIG_CMD_PING=y
-CONFIG_CMD_TFTP=y
-CONFIG_FS_TFTP=y
 CONFIG_DRIVER_NET_DM9K=y
 # CONFIG_SPI is not set
 CONFIG_USB=y
-- 
2.0.0.rc2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 4/9] mips: dlink-dir-320: refresh defconfig

[Sascha Hauer]

Fixes:

arch/mips/configs/dlink-dir-320_defconfig:52:warning: override: reassigning to symbol CMD_DHCP
arch/mips/configs/dlink-dir-320_defconfig:54:warning: override: reassigning to symbol CMD_PING
arch/mips/configs/dlink-dir-320_defconfig:55:warning: override: reassigning to symbol CMD_TFTP
arch/mips/configs/dlink-dir-320_defconfig:64:warning: override: reassigning to symbol FS_TFTP

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 arch/mips/configs/dlink-dir-320_defconfig | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/arch/mips/configs/dlink-dir-320_defconfig b/arch/mips/configs/dlink-dir-320_defconfig
index 2ff9dd7..ab29cf3 100644
--- a/arch/mips/configs/dlink-dir-320_defconfig
+++ b/arch/mips/configs/dlink-dir-320_defconfig
@@ -49,11 +49,7 @@ CONFIG_CMD_OF_PROPERTY=y
 CONFIG_CMD_OFTREE=y
 CONFIG_CMD_TIME=y
 CONFIG_NET=y
-CONFIG_CMD_DHCP=y
 CONFIG_NET_NFS=y
-CONFIG_CMD_PING=y
-CONFIG_CMD_TFTP=y
-CONFIG_FS_TFTP=y
 CONFIG_NET_NETCONSOLE=y
 CONFIG_NET_RESOLV=y
 CONFIG_OFDEVICE=y
-- 
2.0.0.rc2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 5/9] mips: ar9331: Add missing #address-cells/#size-cells properties

[Sascha Hauer]

SPI nodes need valid #address-cells/#size-cells properties.
Fixes:

Warning (reg_format): "reg" property in /soc/spi@bf000000/m25p80@0 has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
Warning (avoid_default_addr_size): Relying on default #address-cells value for /soc/spi@bf000000/m25p80@0
Warning (avoid_default_addr_size): Relying on default #size-cells value for /soc/spi@bf000000/m25p80@0

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 arch/mips/dts/ar9331.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/mips/dts/ar9331.dtsi b/arch/mips/dts/ar9331.dtsi
index 9485fbf..8280588 100644
--- a/arch/mips/dts/ar9331.dtsi
+++ b/arch/mips/dts/ar9331.dtsi
@@ -24,6 +24,8 @@
 		};
 
 		spi: spi@bf000000{
+			#address-cells = <1>;
+			#size-cells = <0>;
 			compatible = "qca,ath79-spi";
 			reg = <0xbf000000 0x01000000>;
 			status = "disabled";
-- 
2.0.0.rc2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 6/9] PPC: FSL DDR: Fix compiler warning

[Sascha Hauer]

Fixes:

arch/ppc/boards/freescale-p1022ds/ddr.c: In function 'fsl_ddr_board_info':
arch/ppc/boards/freescale-p1022ds/ddr.c:39:21: warning: assignment discards 'const' qualifier from pointer target type [enabled by default]

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 arch/ppc/include/asm/fsl_ddr_sdram.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/ppc/include/asm/fsl_ddr_sdram.h b/arch/ppc/include/asm/fsl_ddr_sdram.h
index f0f3a63..2c45608 100644
--- a/arch/ppc/include/asm/fsl_ddr_sdram.h
+++ b/arch/ppc/include/asm/fsl_ddr_sdram.h
@@ -90,7 +90,7 @@ struct ddr_board_info_s {
 	uint32_t i2c_slave;
 	uint32_t i2c_speed;
 	void __iomem *i2c_base;
-	uint8_t *spd_i2c_addr;
+	const uint8_t *spd_i2c_addr;
 };
 
 /*
-- 
2.0.0.rc2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 7/9] commands: drvinfo: Make locally used function static

[Sascha Hauer]

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 commands/drvinfo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/commands/drvinfo.c b/commands/drvinfo.c
index 161118a..4a4b957 100644
--- a/commands/drvinfo.c
+++ b/commands/drvinfo.c
@@ -18,7 +18,7 @@
 #include <command.h>
 #include <driver.h>
 
-int do_drvinfo(int argc, char *argv[])
+static int do_drvinfo(int argc, char *argv[])
 {
 	struct driver_d *drv;
 	struct device_d *dev;
-- 
2.0.0.rc2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 8/9] gui: IMAGE_RENDERER does not depend on VIDEO

[Sascha Hauer]

Image renderer may not be particularly useful without framebuffer
support, but technically it does not depend on VIDEO. Fixes:

warning: (CMD_SPLASH) selects IMAGE_RENDERER which has unmet direct dependencies (VIDEO)

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 lib/gui/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lib/gui/Kconfig b/lib/gui/Kconfig
index da71bae..eac9597 100644
--- a/lib/gui/Kconfig
+++ b/lib/gui/Kconfig
@@ -2,7 +2,6 @@ menu "Library gui routines"
 
 config IMAGE_RENDERER
 	bool
-	depends on VIDEO
 	select FILETYPE
 
 if IMAGE_RENDERER
-- 
2.0.0.rc2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 9/9] mips: Add builtin dtb to dtb-y

[Sascha Hauer]

Otherwise a rebuild of the dtb file is triggered each build.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 arch/mips/dts/Makefile | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/mips/dts/Makefile b/arch/mips/dts/Makefile
index 3ee8924..348b814 100644
--- a/arch/mips/dts/Makefile
+++ b/arch/mips/dts/Makefile
@@ -1,6 +1,8 @@
 
-BUILTIN_DTB := $(patsubst "%",%,$(CONFIG_BUILTIN_DTB_NAME)).dtb.o
-obj-$(CONFIG_BUILTIN_DTB) += $(BUILTIN_DTB)
+BUILTIN_DTB := $(patsubst "%",%,$(CONFIG_BUILTIN_DTB_NAME))
+obj-$(CONFIG_BUILTIN_DTB) += $(BUILTIN_DTB).dtb.o
+
+dtb-y += ${BUILTIN_DTB}.dtb
 
 targets += dtbs
 targets += $(dtb-y)
-- 
2.0.0.rc2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH 4/9] mips: dlink-dir-320: refresh defconfig

[Antony Pavlov]

On Thu,  5 Jun 2014 10:23:39 +0200
Sascha Hauer <s.hauer@pengutronix.de> wrote:

'[PATCH] MIPS: dlink-dir-320_defconfig: drop duplicated symbols':
  http://lists.infradead.org/pipermail/barebox/2014-May/019272.html

My original patch has no duplicates either:
  http://lists.infradead.org/pipermail/barebox/2014-May/019244.html

> Fixes:
> 
> arch/mips/configs/dlink-dir-320_defconfig:52:warning: override: reassigning to symbol CMD_DHCP
> arch/mips/configs/dlink-dir-320_defconfig:54:warning: override: reassigning to symbol CMD_PING
> arch/mips/configs/dlink-dir-320_defconfig:55:warning: override: reassigning to symbol CMD_TFTP
> arch/mips/configs/dlink-dir-320_defconfig:64:warning: override: reassigning to symbol FS_TFTP
> 
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
>  arch/mips/configs/dlink-dir-320_defconfig | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/arch/mips/configs/dlink-dir-320_defconfig b/arch/mips/configs/dlink-dir-320_defconfig
> index 2ff9dd7..ab29cf3 100644
> --- a/arch/mips/configs/dlink-dir-320_defconfig
> +++ b/arch/mips/configs/dlink-dir-320_defconfig
> @@ -49,11 +49,7 @@ CONFIG_CMD_OF_PROPERTY=y
>  CONFIG_CMD_OFTREE=y
>  CONFIG_CMD_TIME=y
>  CONFIG_NET=y
> -CONFIG_CMD_DHCP=y
>  CONFIG_NET_NFS=y
> -CONFIG_CMD_PING=y
> -CONFIG_CMD_TFTP=y
> -CONFIG_FS_TFTP=y
>  CONFIG_NET_NETCONSOLE=y
>  CONFIG_NET_RESOLV=y
>  CONFIG_OFDEVICE=y
> -- 
> 2.0.0.rc2
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox


-- 
-- 
Best regards,
  Antony Pavlov

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH 4/9] mips: dlink-dir-320: refresh defconfig

[Sascha Hauer]

On Thu, Jun 05, 2014 at 01:42:09PM +0400, Antony Pavlov wrote:
> On Thu,  5 Jun 2014 10:23:39 +0200
> Sascha Hauer <s.hauer@pengutronix.de> wrote:
> 
> '[PATCH] MIPS: dlink-dir-320_defconfig: drop duplicated symbols':
>   http://lists.infradead.org/pipermail/barebox/2014-May/019272.html
> 
> My original patch has no duplicates either:
>   http://lists.infradead.org/pipermail/barebox/2014-May/019244.html

This came in with a combination of Holgers patches:

c524f74 commands: NET_DHCP -> CMD_DHCP
5bd055b commands: NET_PING -> CMD_PING
26a3410 commands: HUSH_GETOPT -> CMD_GETOPT

And some not-so-perfect merges from me.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox