From: Sascha Hauer <s.hauer@pengutronix.de>
To: Alexander Aring <alex.aring@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] common: resource: print conflicts as warning
Date: Tue, 24 Jun 2014 08:07:56 +0200 [thread overview]
Message-ID: <20140624060756.GY15686@pengutronix.de> (raw)
In-Reply-To: <1403510400-13562-1-git-send-email-alex.aring@gmail.com>
On Mon, Jun 23, 2014 at 10:00:00AM +0200, Alexander Aring wrote:
> Crazy things happen if there are resource conflicts and a device probe
> runs dev_request_mem_region. The dev_request_mem_region returns a
> start pointer which is zero. The probe function doesn't check on this
> and probing the device on zero base address.
>
> To debug this in debug log level there are many other outputs. This patch
> replace the debug print to a warning printout. A conflict should
> normally never happen. If there is a conflict it's much easier to see it
> with this patch.
>
> Signed-off-by: Alexander Aring <alex.aring@gmail.com>
Applied, thanks
Sascha
> ---
> common/resource.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/resource.c b/common/resource.c
> index fe4680e..1ea2a75 100644
> --- a/common/resource.c
> +++ b/common/resource.c
> @@ -71,7 +71,7 @@ struct resource *__request_region(struct resource *parent,
> goto ok;
> if (start > r->end)
> continue;
> - debug("%s: 0x%08llx:0x%08llx conflicts with 0x%08llx:0x%08llx\n",
> + pr_warn("%s: 0x%08llx:0x%08llx conflicts with 0x%08llx:0x%08llx\n",
> __func__,
> (unsigned long long)start,
> (unsigned long long)end,
> --
> 2.0.0
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2014-06-24 6:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-23 8:00 Alexander Aring
2014-06-24 6:07 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140624060756.GY15686@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=alex.aring@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox