From: Sascha Hauer <s.hauer@pengutronix.de>
To: Holger Schurig <holgerschurig@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 4/4] sandbox: allow "make ARCH=sandbox allyesconfig"
Date: Thu, 26 Jun 2014 21:23:52 +0200 [thread overview]
Message-ID: <20140626192352.GG14257@pengutronix.de> (raw)
In-Reply-To: <1403772557-28482-5-git-send-email-holgerschurig@gmail.com>
On Thu, Jun 26, 2014 at 10:49:17AM +0200, Holger Schurig wrote:
> Compiling the tree with allyesconfig is helpful because different
> compilers (gcc, clang) or static checkers (e.g. clang's scan-build)
> can then process and check more code.
>
> This patch introduces two new configuration symbols that Kconfig files
> can depend on. That way, code that is only working where a cache or DMA
> implementation exists can be opted out.
>
> Signed-off-by: Holger Schurig <holgerschurig@gmail.com>
> ---
> common/Kconfig | 21 +++++++++++++++++++++
> drivers/ata/Kconfig | 1 +
> drivers/input/Kconfig | 2 +-
> drivers/net/Kconfig | 4 ++++
> drivers/regulator/Kconfig | 1 +
> drivers/usb/host/Kconfig | 1 +
> drivers/video/imx-ipu-v3/Kconfig | 1 +
> 7 files changed, 30 insertions(+), 1 deletion(-)
>
> diff --git a/common/Kconfig b/common/Kconfig
> index 1afee93..0bf5d2c 100644
> --- a/common/Kconfig
> +++ b/common/Kconfig
> @@ -25,6 +25,26 @@ config ENV_HANDLING
> select CRC32
> bool
>
> +config HAS_CACHE
> + bool
> + default n if SANDBOX
> + default y
> + help
> + This allows you do run "make ARCH=sandbox allyesconfig".
> +
> + Drivers that depend on a cache implementation can depend on this
> + config, so that you don't get a compilation error.
> +
> +config HAS_DMA
> + bool
> + default n if SANDBOX
> + default y
> + help
> + This allows you do run "make ARCH=sandbox allyesconfig".
> +
> + Drivers that depend on a DMA implementation can depend on this
> + config, so that you don't get a compilation error.
Only ARM implements the dma_* functions. Can we skip the 'default x'
here and select HAS_DMA from the ARM Kconfig file?
Same with HAS_CACHE. The functions are implemented by ppc, nios2 and
openrisc.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2014-06-26 19:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-26 8:49 Holger Schurig
2014-06-26 19:23 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140626192352.GG14257@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=holgerschurig@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox