From: Sascha Hauer <s.hauer@pengutronix.de>
To: Holger Schurig <holgerschurig@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v2] menutree: let it select GLOB and GLOB_SORT
Date: Wed, 2 Jul 2014 07:27:11 +0200 [thread overview]
Message-ID: <20140702052711.GR14257@pengutronix.de> (raw)
In-Reply-To: <1404202086-1775-1-git-send-email-holgerschurig@gmail.com>
On Tue, Jul 01, 2014 at 10:08:06AM +0200, Holger Schurig wrote:
> The menutree doesn't select CONFIG_GLOB, but it depends on it. Without
> it will just hang. So let it select it automatically. Also remove the
> dependency of CONFIG_GLOB on CONFIG_HUSH, because glob() will run with
> the simple shell as well.
>
> Also let CONFIG_MENUTREE select on CONFIG_GLOB_SORT. While is not
> strictly needed, many people use menu/00-foo menu/10-bar menu/20-barf
> to sort their menu entries. So select it out of convenience.
>
> Signed-off-by: Holger Schurig <holgerschurig@gmail.com>
Took this one instead.
Sascha
> ---
>
> v2: just changed the commit text
>
> common/Kconfig | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/common/Kconfig b/common/Kconfig
> index 1afee93..bba7f15 100644
> --- a/common/Kconfig
> +++ b/common/Kconfig
> @@ -61,6 +61,8 @@ config BAREBOX_UPDATE
>
> config MENUTREE
> bool
> + select GLOB
> + select GLOB_SORT
>
> menu "General Settings"
>
> @@ -338,11 +340,13 @@ config MAXARGS
>
> config GLOB
> bool
> - prompt "hush globbing support"
> - depends on SHELL_HUSH
> + prompt "globbing support"
> help
> If you want to use wildcards like * or ? say y here.
>
> + Globbing can be used in the HUSH shell, but is also used
> + internally in the menutree command.
> +
> config GLOB_SORT
> select QSORT
> bool
> --
> 1.7.10.4
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2014-07-02 5:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-01 8:08 Holger Schurig
2014-07-02 5:27 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140702052711.GR14257@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=holgerschurig@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox