From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1X2D4v-0003YR-2d for barebox@lists.infradead.org; Wed, 02 Jul 2014 05:27:33 +0000 Date: Wed, 2 Jul 2014 07:27:11 +0200 From: Sascha Hauer Message-ID: <20140702052711.GR14257@pengutronix.de> References: <1404202086-1775-1-git-send-email-holgerschurig@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1404202086-1775-1-git-send-email-holgerschurig@gmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH v2] menutree: let it select GLOB and GLOB_SORT To: Holger Schurig Cc: barebox@lists.infradead.org On Tue, Jul 01, 2014 at 10:08:06AM +0200, Holger Schurig wrote: > The menutree doesn't select CONFIG_GLOB, but it depends on it. Without > it will just hang. So let it select it automatically. Also remove the > dependency of CONFIG_GLOB on CONFIG_HUSH, because glob() will run with > the simple shell as well. > > Also let CONFIG_MENUTREE select on CONFIG_GLOB_SORT. While is not > strictly needed, many people use menu/00-foo menu/10-bar menu/20-barf > to sort their menu entries. So select it out of convenience. > > Signed-off-by: Holger Schurig Took this one instead. Sascha > --- > > v2: just changed the commit text > > common/Kconfig | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/common/Kconfig b/common/Kconfig > index 1afee93..bba7f15 100644 > --- a/common/Kconfig > +++ b/common/Kconfig > @@ -61,6 +61,8 @@ config BAREBOX_UPDATE > > config MENUTREE > bool > + select GLOB > + select GLOB_SORT > > menu "General Settings" > > @@ -338,11 +340,13 @@ config MAXARGS > > config GLOB > bool > - prompt "hush globbing support" > - depends on SHELL_HUSH > + prompt "globbing support" > help > If you want to use wildcards like * or ? say y here. > > + Globbing can be used in the HUSH shell, but is also used > + internally in the menutree command. > + > config GLOB_SORT > select QSORT > bool > -- > 1.7.10.4 > > > _______________________________________________ > barebox mailing list > barebox@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/barebox > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox