From: Sascha Hauer <s.hauer@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] pci: pci_alloc_bus(): use xzalloc() instead of kzalloc()
Date: Wed, 9 Jul 2014 07:32:41 +0200 [thread overview]
Message-ID: <20140709053241.GA23235@pengutronix.de> (raw)
In-Reply-To: <1404850991-28028-1-git-send-email-antonynpavlov@gmail.com>
On Wed, Jul 09, 2014 at 12:23:11AM +0400, Antony Pavlov wrote:
> Also drop redundant xzalloc() result check
> as xzalloc() does not return in case of memory allocation error.
>
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
Applied, thanks
Sascha
> ---
> drivers/pci/pci.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index ad9350f..3d88b0f 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -16,14 +16,14 @@ static struct pci_bus *pci_alloc_bus(void)
> {
> struct pci_bus *b;
>
> - b = kzalloc(sizeof(*b), GFP_KERNEL);
> - if (b) {
> - INIT_LIST_HEAD(&b->node);
> - INIT_LIST_HEAD(&b->children);
> - INIT_LIST_HEAD(&b->devices);
> - INIT_LIST_HEAD(&b->slots);
> - INIT_LIST_HEAD(&b->resources);
> - }
> + b = xzalloc(sizeof(*b));
> +
> + INIT_LIST_HEAD(&b->node);
> + INIT_LIST_HEAD(&b->children);
> + INIT_LIST_HEAD(&b->devices);
> + INIT_LIST_HEAD(&b->slots);
> + INIT_LIST_HEAD(&b->resources);
> +
> return b;
> }
>
> --
> 2.0.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2014-07-09 5:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-08 20:23 Antony Pavlov
2014-07-09 5:32 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140709053241.GA23235@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox