mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: "barebox@lists.infradead.org" <barebox@lists.infradead.org>
Subject: Re: [RFC v3 4/5] commands: add hwclock
Date: Mon, 21 Jul 2014 10:11:50 +0200	[thread overview]
Message-ID: <20140721081150.GT23235@pengutronix.de> (raw)
In-Reply-To: <20140721111025.4a0d6d2c1ef5977e1d45f152@gmail.com>

On Mon, Jul 21, 2014 at 11:10:25AM +0400, Antony Pavlov wrote:
> On Mon, 21 Jul 2014 08:41:06 +0200
> Sascha Hauer <s.hauer@pengutronix.de> wrote:
> 
> > On Sun, Jul 20, 2014 at 09:55:22AM +0400, Antony Pavlov wrote:
> > > On Sat, 19 Jul 2014 21:02:22 +0200
> > > Holger Schurig <holgerschurig@gmail.com> wrote:
> > > 
> > > > I'd prefer a more logical format (and that is also in the help).
> > > > However, in this case I wouldn't name the command "hwclock", but maybe
> > > > "setclock".
> > > 
> > > hwclock allows to use a logical format!
> > > 
> > > e.g. here is a quote from hwclock manpage:
> > > 
> > >      --date=date_string
> > >               You  need this option if you specify the --set or --predict functions, otherwise
> > >               it is ignored.  It specifies the time to which to set the Hardware Clock, or the
> > >               time  for which to predict the Hardware Clock reading.  The value of this option
> > >               is an argument to the date(1) program.  For example:
> > > 
> > >                   hwclock --set --date="2011-08-14 16:45:05"
> > 
> > Is this format easy enough to parse? If yes, that sounds like a good
> > format.
> 
> So you have no objections on using a logical format :)

No, not at all ;)

> 
> I can make a small review on conventional date_string formats so we can discuss most appropriate one.

Nice, thanks.

I think we can always add additional formats using different command
line switches, but the better we chose our default format the lesser
need we'll have to add additional formats.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2014-07-21  8:12 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-14 20:48 [RFC v3 0/5] add rtc support Antony Pavlov
2014-07-14 20:48 ` [RFC v3 1/5] lib: import 'bcd' from linux-3.15 Antony Pavlov
2014-07-14 20:48 ` [RFC v3 2/5] add rtc support Antony Pavlov
2014-07-14 20:48 ` [RFC v3 3/5] rtc: import ds1307 driver from linux-3.15 Antony Pavlov
2014-07-14 20:48 ` [RFC v3 4/5] commands: add hwclock Antony Pavlov
2014-07-18  5:44   ` Sascha Hauer
2014-07-18  7:36     ` Antony Pavlov
2014-07-19 19:02       ` Holger Schurig
2014-07-20  5:55         ` Antony Pavlov
2014-07-21  6:41           ` Sascha Hauer
2014-07-21  7:10             ` Antony Pavlov
2014-07-21  8:11               ` Sascha Hauer [this message]
2014-07-21 15:41                 ` Antony Pavlov
2014-07-21 17:34                   ` Antony Pavlov
2014-07-24 19:17                   ` Antony Pavlov
2014-07-25  7:38                   ` Sascha Hauer
2014-07-25  7:39     ` Sascha Hauer
2014-07-14 20:48 ` [RFC v3 5/5] ARM: versatilepb_defconfig: enable RTC support Antony Pavlov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140721081150.GT23235@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=antonynpavlov@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox