mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* tftp: more helpful help text
@ 2014-07-21 21:37 Pavel Machek
  2014-07-22  5:43 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Pavel Machek @ 2014-07-21 21:37 UTC (permalink / raw)
  To: barebox, s.hauer


It took me a while to figure out syntax of tftp command, document that 
server address is taken from environment.

Signed-off-by: Pavel Machek <pavel@ucw.cz>

diff --git a/commands/tftp.c b/commands/tftp.c
index c066631..62b9424 100644
--- a/commands/tftp.c
+++ b/commands/tftp.c
@@ -92,7 +92,8 @@ err_free:
 }
 
 BAREBOX_CMD_HELP_START(tftp)
-BAREBOX_CMD_HELP_TEXT("Load (or save) a file via TFTP.")
+BAREBOX_CMD_HELP_TEXT("Load (or save) a file via TFTP. SOURCE is a path on server,")
+BAREBOX_CMD_HELP_TEXT("server address is taken from the environment (ethX.serverip).")
 BAREBOX_CMD_HELP_TEXT("")
 BAREBOX_CMD_HELP_TEXT("Options:")
 BAREBOX_CMD_HELP_OPT ("-p", "push to TFTP server")

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: tftp: more helpful help text
  2014-07-21 21:37 tftp: more helpful help text Pavel Machek
@ 2014-07-22  5:43 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2014-07-22  5:43 UTC (permalink / raw)
  To: Pavel Machek; +Cc: barebox

On Mon, Jul 21, 2014 at 11:37:37PM +0200, Pavel Machek wrote:
> 
> It took me a while to figure out syntax of tftp command, document that 
> server address is taken from environment.
> 
> Signed-off-by: Pavel Machek <pavel@ucw.cz>

Applied, thanks

Sascha

> 
> diff --git a/commands/tftp.c b/commands/tftp.c
> index c066631..62b9424 100644
> --- a/commands/tftp.c
> +++ b/commands/tftp.c
> @@ -92,7 +92,8 @@ err_free:
>  }
>  
>  BAREBOX_CMD_HELP_START(tftp)
> -BAREBOX_CMD_HELP_TEXT("Load (or save) a file via TFTP.")
> +BAREBOX_CMD_HELP_TEXT("Load (or save) a file via TFTP. SOURCE is a path on server,")
> +BAREBOX_CMD_HELP_TEXT("server address is taken from the environment (ethX.serverip).")
>  BAREBOX_CMD_HELP_TEXT("")
>  BAREBOX_CMD_HELP_TEXT("Options:")
>  BAREBOX_CMD_HELP_OPT ("-p", "push to TFTP server")
> 
> -- 
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-07-22  5:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-21 21:37 tftp: more helpful help text Pavel Machek
2014-07-22  5:43 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox