From: Sascha Hauer <s.hauer@pengutronix.de>
To: Holger Schurig <holgerschurig@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] commands: fix memset command
Date: Tue, 22 Jul 2014 22:16:06 +0200 [thread overview]
Message-ID: <20140722201606.GE23235@pengutronix.de> (raw)
In-Reply-To: <1406023122-498-1-git-send-email-holgerschurig@gmail.com>
On Tue, Jul 22, 2014 at 11:58:42AM +0200, Holger Schurig wrote:
> Before:
>
> barebox:/ memset -d /dev/fb0 -l 0 10 0xdeadbeef
> write: No space left on device
> barebox:/ md -s /dev/fb0
> 00000000: 0a0a0a0a 0a0a0a0a 0a0a0a0a 0a0a0a0a ................
> ...
>
> After:
>
> barebox:/ memset -d /dev/fb0 -l 0 10 0xdeadbeef
> barebox:/ md -s /dev/fb0
> 00000000: deadbeef deadbeef deadbeef deadbeef ................
> 00000010: deadbeef deadbeef deadbeef deadbeef ................
> 00000020: deadbeef deadbeef 00ffffff 00ffffff ................
> 00000030: 00ffffff 00ffffff 00ffffff 00ffffff ...............
Nice.
The documentation still has:
Fills the first COUNT bytes at offset ADDR with byte DATA
Should probably be something like:
Fills the first COUNT values at offset ADDR with DATA
Sascha
>
> Signed-off-by: Holger Schurig <holgerschurig@gmail.com>
> ---
> commands/memset.c | 14 ++------------
> 1 file changed, 2 insertions(+), 12 deletions(-)
>
> diff --git a/commands/memset.c b/commands/memset.c
> index f869306..4afe404 100644
> --- a/commands/memset.c
> +++ b/commands/memset.c
> @@ -39,7 +39,6 @@ static int do_memset(int argc, char *argv[])
> {
> loff_t s, c, n;
> int fd;
> - char *buf;
> int mode = O_RWSIZE_1;
> int ret = 1;
> char *file = "/dev/mem";
> @@ -59,28 +58,19 @@ static int do_memset(int argc, char *argv[])
> if (fd < 0)
> return 1;
>
> - buf = xmalloc(RW_BUF_SIZE);
> - memset(buf, c, RW_BUF_SIZE);
>
> - while (n > 0) {
> - int now;
> -
> - now = min((loff_t)RW_BUF_SIZE, n);
> -
> - ret = write(fd, buf, now);
> + while (c--) {
> + ret = write(fd, &n, mode >> O_RWSIZE_SHIFT);
> if (ret < 0) {
> perror("write");
> ret = 1;
> goto out;
> }
> -
> - n -= now;
> }
>
> ret = 0;
> out:
> close(fd);
> - free(buf);
>
> return ret;
> }
> --
> 1.7.10.4
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2014-07-22 20:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-22 9:58 Holger Schurig
2014-07-22 20:16 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140722201606.GE23235@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=holgerschurig@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox