From: Sascha Hauer <s.hauer@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [RFC v3 4/5] commands: add hwclock
Date: Fri, 25 Jul 2014 09:39:45 +0200 [thread overview]
Message-ID: <20140725073945.GJ23282@pengutronix.de> (raw)
In-Reply-To: <20140718054413.GL23235@pengutronix.de>
On Fri, Jul 18, 2014 at 07:44:13AM +0200, Sascha Hauer wrote:
> On Tue, Jul 15, 2014 at 12:48:35AM +0400, Antony Pavlov wrote:
> > +{
> > + struct rtc_device *r;
> > + struct rtc_time tm;
> > + struct rtc_time stm;
> > + char rtc_name[16] = "rtc0";
> > + char *env_name = NULL;
> > + int opt;
> > + int set = 0;
> > +
> > + while ((opt = getopt(argc, argv, "f:s:e:")) > 0) {
> > + switch (opt) {
> > + case 'f':
> > + strncpy(rtc_name, optarg, 16);
> > + break;
> > + case 's':
> > + memset(&stm, 0, sizeof(stm));
> > + parse_datestr(optarg, &stm);
The result value should really be checked.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2014-07-25 7:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-14 20:48 [RFC v3 0/5] add rtc support Antony Pavlov
2014-07-14 20:48 ` [RFC v3 1/5] lib: import 'bcd' from linux-3.15 Antony Pavlov
2014-07-14 20:48 ` [RFC v3 2/5] add rtc support Antony Pavlov
2014-07-14 20:48 ` [RFC v3 3/5] rtc: import ds1307 driver from linux-3.15 Antony Pavlov
2014-07-14 20:48 ` [RFC v3 4/5] commands: add hwclock Antony Pavlov
2014-07-18 5:44 ` Sascha Hauer
2014-07-18 7:36 ` Antony Pavlov
2014-07-19 19:02 ` Holger Schurig
2014-07-20 5:55 ` Antony Pavlov
2014-07-21 6:41 ` Sascha Hauer
2014-07-21 7:10 ` Antony Pavlov
2014-07-21 8:11 ` Sascha Hauer
2014-07-21 15:41 ` Antony Pavlov
2014-07-21 17:34 ` Antony Pavlov
2014-07-24 19:17 ` Antony Pavlov
2014-07-25 7:38 ` Sascha Hauer
2014-07-25 7:39 ` Sascha Hauer [this message]
2014-07-14 20:48 ` [RFC v3 5/5] ARM: versatilepb_defconfig: enable RTC support Antony Pavlov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140725073945.GJ23282@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox