From: Antony Pavlov <antonynpavlov@gmail.com>
To: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [RFC] led: try to get LED's label from the 'label' property
Date: Tue, 29 Jul 2014 09:49:01 +0400 [thread overview]
Message-ID: <20140729094901.bb2d9f7329520a6857f5cf39@gmail.com> (raw)
In-Reply-To: <53D364AD.1040002@gmail.com>
On Sat, 26 Jul 2014 10:19:57 +0200
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> wrote:
> On 07/26/2014 02:11 AM, Antony Pavlov wrote:
> > Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> > ---
> > drivers/led/led-gpio.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/led/led-gpio.c b/drivers/led/led-gpio.c
> > index 7bb3b49..31ae627 100644
> > --- a/drivers/led/led-gpio.c
> > +++ b/drivers/led/led-gpio.c
> > @@ -212,7 +212,9 @@ static int led_gpio_of_probe(struct device_d *dev)
> > continue;
> >
> > gled = xzalloc(sizeof(*gled));
> > - gled->led.name = xstrdup(child->name);
> > + gled->led.name = of_get_property(child, "label", NULL);
>
> IIRC, back the days this was introduced, there was no "label" property.
Do you mean "the days barebox.git/drivers/led/led-gpio.c was introduced"?
commit 91d781f51df5d4de23d09a6777bfc968a0a7ca68
Author: Sascha Hauer <s.hauer@pengutronix.de>
Date: Sat Dec 18 14:36:02 2010 +0100
LED: Add gpio LED support
But linux.git/drivers/leds/leds-gpio.c was introduce in
commit a7d878af94b223013a48078e0c8c0a654c24a057
Author: Trent Piepho <tpiepho@freescale.com>
Date: Sat Jan 10 17:26:01 2009 +0000
leds: Add openfirmware platform device support
> Anyway, of_get_property gives you the reference to something that can
> change, i.e. if you remove/modify the corresponding node or property
> you'll end up with a gleg->led.name pointing to something old or gone.
>
> Sebastian
>
> > + if (!gled->led.name)
> > + gled->led.name = xstrdup(child->name);
> > gled->gpio = gpio;
> > gled->active_low = (flags & OF_GPIO_ACTIVE_LOW) ? 1 : 0;
> >
> >
>
--
--
Best regards,
Antony Pavlov
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2014-07-29 5:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-26 0:11 Antony Pavlov
2014-07-26 8:19 ` Sebastian Hesselbarth
2014-07-29 5:49 ` Antony Pavlov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140729094901.bb2d9f7329520a6857f5cf39@gmail.com \
--to=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox