From: Sascha Hauer <s.hauer@pengutronix.de>
To: Michael Olbrich <m.olbrich@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/2] EFI: fix error handling in efi_get_boot()
Date: Mon, 1 Sep 2014 11:03:40 +0200 [thread overview]
Message-ID: <20140901090340.GI5352@pengutronix.de> (raw)
In-Reply-To: <1407836241-17620-1-git-send-email-m.olbrich@pengutronix.de>
On Tue, Aug 12, 2014 at 11:37:20AM +0200, Michael Olbrich wrote:
> efi_get_global_var() returns an error code, not NULL when it fails.
>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
Applied this one, thanks
Sascha
> ---
> arch/efi/efi/efi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/efi/efi/efi.c b/arch/efi/efi/efi.c
> index ff97783..7de8ec8 100644
> --- a/arch/efi/efi/efi.c
> +++ b/arch/efi/efi/efi.c
> @@ -104,7 +104,7 @@ struct efi_boot *efi_get_boot(int num)
>
> free(name);
>
> - if (!buf) {
> + if (IS_ERR(buf)) {
> free(boot);
> return NULL;
> }
> --
> 2.0.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2014-09-01 9:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-12 9:37 Michael Olbrich
2014-08-12 9:37 ` [PATCH 2/2] EFI: handle more boot devices Michael Olbrich
2014-09-01 9:06 ` Sascha Hauer
2014-09-01 10:02 ` Michael Olbrich
2014-09-01 10:12 ` Sascha Hauer
2014-09-01 9:03 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140901090340.GI5352@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=m.olbrich@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox