From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Raphaël Poggi" <poggi.raph@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/5] mtd: nand: remove NAND_ATMEL_PMECC
Date: Mon, 1 Sep 2014 11:49:28 +0200 [thread overview]
Message-ID: <20140901094928.GP5352@pengutronix.de> (raw)
In-Reply-To: <CACqcpZAt3xSpLnkYTfmNF+2ShENCATd1_VP1m=jq3CXGOnS1QA@mail.gmail.com>
On Wed, Aug 06, 2014 at 09:21:52AM +0200, Raphaël Poggi wrote:
> Ok, I did it because we need a structure member to retrieve
> "atmel,has-pmecc" from device tree.
>
> Is this ok if I add the has_pmecc member (feed by atmel_nand_of_init),
> let the NAND_ATMEL_PMECC, and the if will be like :
>
> if (IS_ENABLED(CONFIG_NAND_ATMEL_PMECC) || pdata->has_pmecc)
Shouldn't this be && instead of ||?
Otherwise this approach should be fine.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2014-09-01 9:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-05 9:14 [PATCH v2 0/5] Add device tree support of Atmel NAND driver Raphaël Poggi
2014-08-05 9:14 ` [PATCH 1/5] mtd: nand: remove NAND_ATMEL_PMECC Raphaël Poggi
2014-08-06 4:08 ` Jean-Christophe PLAGNIOL-VILLARD
2014-08-06 7:21 ` Raphaël Poggi
2014-09-01 9:49 ` Sascha Hauer [this message]
2014-08-05 9:14 ` [PATCH 2/5] board: atmel: initialise the has_pmecc member Raphaël Poggi
2014-08-05 9:14 ` [PATCH 3/5] mtd: atmel_nand: retrieve ecc_mode from pdata Raphaël Poggi
2014-08-05 9:14 ` [PATCH 4/5] board: atmel: initialise ecc_mode Raphaël Poggi
2014-09-01 9:54 ` Sascha Hauer
2014-08-05 9:14 ` [PATCH 5/5] mtd: atmel_nand: add support for device tree Raphaël Poggi
2014-08-05 9:40 ` [PATCH v2 0/5] Add device tree support of Atmel NAND driver Raphaël Poggi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140901094928.GP5352@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=poggi.raph@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox