From: Sascha Hauer <s.hauer@pengutronix.de>
To: Alexander Aring <alex.aring@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] commands: saveenv: Fix comment about directories in help text
Date: Mon, 1 Sep 2014 12:51:21 +0200 [thread overview]
Message-ID: <20140901105121.GW5352@pengutronix.de> (raw)
In-Reply-To: <20140801064502.GA27679@omega>
On Fri, Aug 01, 2014 at 08:45:04AM +0200, Alexander Aring wrote:
> Hi Sascha,
>
> On Fri, Aug 01, 2014 at 08:17:10AM +0200, Sascha Hauer wrote:
> > envfs indeed handles directories, at least since 2007:
> >
> > | commit 913691eccd13c1509470eb8b059aa0beecc6d8d8
> > | Author: Sascha Hauer <s.hauer@pengutronix.de>
> > | Date: Tue Sep 25 12:58:52 2007 +0200
> > |
> > | add directory handling for environment
> >
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > ---
> > commands/saveenv.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/commands/saveenv.c b/commands/saveenv.c
> > index 31d6951..9da733e 100644
> > --- a/commands/saveenv.c
> > +++ b/commands/saveenv.c
> > @@ -60,8 +60,7 @@ BAREBOX_CMD_HELP_TEXT("Save the files in DIRECTORY to the persistent storage dev
> > BAREBOX_CMD_HELP_TEXT("")
> > BAREBOX_CMD_HELP_TEXT("ENVFS is usually a block in flash but can be any other file. If")
> > BAREBOX_CMD_HELP_TEXT("omitted, DIRECTORY defaults to /env and ENVFS defaults to")
> > -BAREBOX_CMD_HELP_TEXT("/dev/env0. Note that envfs can only handle files, directories are being")
> > -BAREBOX_CMD_HELP_TEXT("skipped silently.")
> > +BAREBOX_CMD_HELP_TEXT("/dev/env0.")
>
> but envfs can't handle directories which are empty while saving? :-)
> Maybe we should add this as note or support empty directories.
I think we should add some more general docs how the environment works.
That would be a more appropriate place to add this note. Otherwise we
would have to add it to loadenv aswell.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2014-09-01 10:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-01 6:17 Sascha Hauer
2014-08-01 6:45 ` Alexander Aring
2014-09-01 10:51 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140901105121.GW5352@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=alex.aring@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox