From: Alexander Aring <alex.aring@gmail.com>
To: "Teresa Gámez" <t.gamez@phytec.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 5/5] ARM: phyCORE-AM335x: Update partition table
Date: Thu, 4 Sep 2014 09:15:12 +0200 [thread overview]
Message-ID: <20140904071511.GB13432@omega> (raw)
In-Reply-To: <20140904071258.GA13432@omega>
On Thu, Sep 04, 2014 at 09:12:58AM +0200, Alexander Aring wrote:
> Hi Teresa,
>
> On Thu, Sep 04, 2014 at 08:50:40AM +0200, Teresa Gámez wrote:
> > Added device tree partition and made rootfs partition
> > variable size depending on nand flash size.
> >
> > Signed-off-by: Teresa Gámez <t.gamez@phytec.de>
> > ---
> > arch/arm/dts/am335x-phytec-phycore.dts | 22 ++++++++++++++++++----
> > 1 files changed, 18 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/arm/dts/am335x-phytec-phycore.dts b/arch/arm/dts/am335x-phytec-phycore.dts
> > index 16febd3..047dc15 100644
> > --- a/arch/arm/dts/am335x-phytec-phycore.dts
> > +++ b/arch/arm/dts/am335x-phytec-phycore.dts
> > @@ -194,8 +194,13 @@
> > };
> >
> > partition@3 {
> > + label = "oftree";
> > + reg = <0xc0000 0x20000>;
> > + };
> > +
> > + partition@4 {
> > label = "kernel";
> > - reg = <0xc0000 0x400000>;
> > + reg = <0xe0000 0x400000>;
> > };
> > };
> > };
> > @@ -305,13 +310,22 @@
> > };
> >
> > partition@6 {
> > - label = "kernel";
> > - reg = <0x120000 0x800000>;
> > + label = "oftree";
> > + reg = <0x120000 0x20000>;
> > };
> >
> > partition@7 {
> > + label = "kernel";
> > + reg = <0x140000 0x800000>;
> > + };
> > +
> > + partition@8 {
> > label = "root";
> > - reg = <0x920000 0x1f6e0000>;
> > + /*
> > + * Size 0x0 extends partition to
> > + * end of nand flash.
> > + */
> > + reg = <0x920000 0x0>;
>
> I think this should be 0x940000 insead 0x920000.
>
> From partition7 7 "kernel" you have 0x140000 + 0x800000 = 0x940000.
>
> I simple use the gnome-calculator in hex mode to check it.
>
But in this case it was very obviously. Can't have a two in this
position. :-)
- Alex
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2014-09-04 7:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-04 6:50 [PATCH 1/5] ARM: phyCORE-AM335x: Updated SPI NOR dts entries Teresa Gámez
2014-09-04 6:50 ` [PATCH 2/5] ARM: phyCORE-AM335x: Update RAM Timings Teresa Gámez
2014-09-04 6:50 ` [PATCH 3/5] ARM: phyCORE-AM335x: Fixup RAM setting naming Teresa Gámez
2014-09-04 6:50 ` [PATCH 4/5] ARM: phyCORE-AM335x: Add support for 2x512MB RAM Teresa Gámez
2014-09-04 6:50 ` [PATCH 5/5] ARM: phyCORE-AM335x: Update partition table Teresa Gámez
2014-09-04 7:13 ` Alexander Aring
2014-09-04 7:15 ` Alexander Aring [this message]
2014-09-05 5:37 ` [PATCH 1/5] ARM: phyCORE-AM335x: Updated SPI NOR dts entries Sascha Hauer
2014-09-05 6:32 ` Alexander Aring
2014-09-05 6:51 ` Sascha Hauer
2014-09-05 7:18 ` Alexander Aring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140904071511.GB13432@omega \
--to=alex.aring@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=t.gamez@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox