[PATCH] checkpatch.pl: check for the FSF mailing address

[PATCH] checkpatch.pl: check for the FSF mailing address

[Antony Pavlov]

This check code is imported from Linux v3.16 checkpatch.pl.

Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
---
 scripts/checkpatch.pl | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 153af8d..419436d 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1425,6 +1425,16 @@ sub process {
 			$rpt_cleaners = 1;
 		}
 
+# Check for FSF mailing addresses.
+		if ($rawline =~ /\bwrite to the Free/i ||
+		    $rawline =~ /\b59\s+Temple\s+Pl/i ||
+		    $rawline =~ /\b51\s+Franklin\s+St/i) {
+			my $herevet = "$here\n" . cat_vet($rawline) . "\n";
+			my $msg_type = \&ERROR;
+			$msg_type = \&CHK if ($file);
+			&{$msg_type}("Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. barebox already includes a copy of the GPL.\n" . $herevet)
+		}
+
 # check for Kconfig help text having a real description
 # Only applies when adding the entry originally, after that we do not have
 # sufficient context to determine whether it is indeed long enough.
-- 
2.1.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] checkpatch.pl: check for the FSF mailing address

[Sascha Hauer]

On Thu, Sep 11, 2014 at 01:49:51PM +0400, Antony Pavlov wrote:
> This check code is imported from Linux v3.16 checkpatch.pl.
> 
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>

Ah good move. I hope this helps not getting the address back into the
tree every now and then.

Applied, thanks.

Sascha

> ---
>  scripts/checkpatch.pl | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 153af8d..419436d 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -1425,6 +1425,16 @@ sub process {
>  			$rpt_cleaners = 1;
>  		}
>  
> +# Check for FSF mailing addresses.
> +		if ($rawline =~ /\bwrite to the Free/i ||
> +		    $rawline =~ /\b59\s+Temple\s+Pl/i ||
> +		    $rawline =~ /\b51\s+Franklin\s+St/i) {
> +			my $herevet = "$here\n" . cat_vet($rawline) . "\n";
> +			my $msg_type = \&ERROR;
> +			$msg_type = \&CHK if ($file);
> +			&{$msg_type}("Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. barebox already includes a copy of the GPL.\n" . $herevet)
> +		}
> +
>  # check for Kconfig help text having a real description
>  # Only applies when adding the entry originally, after that we do not have
>  # sufficient context to determine whether it is indeed long enough.
> -- 
> 2.1.0
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox