From: Sascha Hauer <s.hauer@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [RFC] net: dm9k: fix reset routine
Date: Fri, 12 Sep 2014 07:54:54 +0200 [thread overview]
Message-ID: <20140912055454.GT4992@pengutronix.de> (raw)
In-Reply-To: <1410434401-17649-1-git-send-email-antonynpavlov@gmail.com>
On Thu, Sep 11, 2014 at 03:20:01PM +0400, Antony Pavlov wrote:
> Based on Linux's commit:
>
> commit 09ee9f87d02e779e4fc3f5c29212c733d6d6e349
> Author: Michael Abbott <michael.abbott@diamond.ac.uk>
> Date: Wed Oct 16 11:41:33 2013 +0300
>
> dm9000: Implement full reset of DM9000 network device
>
> A Davicom application note for the DM9000 network device recommends
> performing software reset twice to correctly initialise the device.
> Without this reset some devices fail to initialise correctly on
> system startup.
>
> # define NCR_FDX (1 << 3)
> # define NCR_LBK (3 << 1)
> +# define NCR_MAC_LBK (1 << 1)
> # define NCR_RST (1 << 0)
>
> #define DM9K_NSR 0x01
> @@ -471,8 +472,28 @@ static void dm9k_reset(struct dm9k *priv)
> struct device_d *dev = priv->miibus.parent;
>
> dev_dbg(dev, "%s\n", __func__);
> - dm9k_iow(priv, DM9K_NCR, NCR_RST);
> - udelay(1000); /* delay 1ms */
> +
> + /* Reset DM9000, see DM9000 Application Notes V1.22 Jun 11, 2004 page 29
> + * The essential point is that we have to do a double reset, and the
> + * instruction is to set LBK into MAC internal loopback mode.
> + */
> +
> + /* Make all GPIO pins outputs */
> + dm9k_iow(priv, DM9K_GPCR, 0x0F);
> + /* Power internal PHY by writing 0 to GPIO0 pin */
> + dm9k_iow(priv, DM9K_GPR, 0);
> +
> + dm9k_iow(priv, DM9K_NCR, NCR_RST | NCR_MAC_LBK);
> + udelay(100); /* Application note says at least 20 us */
> + if (dm9k_ior(priv, DM9K_NCR) & NCR_RST)
> + dev_err(dev, "dm9000 did not respond to first reset\n");
> +
> + dm9k_iow(priv, DM9K_NCR, 0);
> + dm9k_iow(priv, DM9K_NCR, NCR_RST | NCR_MAC_LBK);
> + udelay(100);
> +
> + if (dm9k_ior(priv, DM9K_NCR) & NCR_RST)
> + dev_err(dev, "dm9000 did not respond to second reset\n");
How about using a loop to save a few bytes? Otherwise fine with me.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2014-09-12 5:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-11 11:20 Antony Pavlov
2014-09-12 5:54 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140912055454.GT4992@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox