From: Sascha Hauer <s.hauer@pengutronix.de>
To: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] pinctrl: fix Kconfig dependencies
Date: Mon, 15 Sep 2014 07:18:32 +0200 [thread overview]
Message-ID: <20140915051832.GW4992@pengutronix.de> (raw)
In-Reply-To: <54130EBA.3080402@gmail.com>
On Fri, Sep 12, 2014 at 05:18:18PM +0200, Sebastian Hesselbarth wrote:
> On 09/12/2014 12:07 PM, Sascha Hauer wrote:
> >- Remove OFDEVICE dependency from PINCTRL. It won't do
> > much then, so add a comment to Kconfig when PINCTRL is
> > selected without OFDEVICE
> >- Let Architectures only select PINCTRL instead of the
> > particular driver. Change the drivers to 'default y if $SOC'
> > to make sure the drivers are still compiled if the corresponding
> > SoC is selected
> >
> >This fixes Kconfig warnings like:
> >
> >warning: (PINCTRL_ARMADA_370 && PINCTRL_ARMADA_XP && PINCTRL_DOVE && PINCTRL_KIRKWOOD) selects PINCTRL which has unmet direct dependencies (OFDEVICE)
> >
> >Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> >---
> > arch/arm/mach-mvebu/Kconfig | 8 ++++----
> > arch/arm/mach-tegra/Kconfig | 6 +++---
> > drivers/pinctrl/Kconfig | 24 ++++++++++++++++--------
> > drivers/pinctrl/mvebu/Kconfig | 8 ++++----
> > drivers/pinctrl/pinctrl-rockchip.c | 3 +++
> > drivers/pinctrl/pinctrl.c | 6 ++++++
> > 6 files changed, 36 insertions(+), 19 deletions(-)
>
> For mvebu, you could also move 'select PINCTRL' to config MACH_MVEBU.
> I guess the same is also true for Tegra?
Yes, every Tegra board has pinctrl, so I moved the select statements to
ARCH_MVEBU / ARCH_TEGRA
>
> But that is just a nit, so
>
> Acked-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Thanks
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2014-09-15 5:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-12 10:07 Sascha Hauer
2014-09-12 15:18 ` Sebastian Hesselbarth
2014-09-15 5:18 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140915051832.GW4992@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox