mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Christian Hemp <c.hemp@phytec.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/4] phy/micrel: disable Asym_Pause support
Date: Wed, 17 Sep 2014 08:55:12 +0200	[thread overview]
Message-ID: <20140917065512.GN4992@pengutronix.de> (raw)
In-Reply-To: <1410785791-27053-1-git-send-email-c.hemp@phytec.de>

On Mon, Sep 15, 2014 at 02:56:28PM +0200, Christian Hemp wrote:
> From: Jan Weitzel <j.weitzel@phytec.de>
> 
> With SUPPORTED_Asym_Pause enabled we need to hotplug the ethernet cable.
> So disable it like done with PHY_ID_KSZ9021.
> 
> Signed-off-by: Jan Weitzel <j.weitzel@phytec.de>
> Signed-off-by: Christian Hemp <c.hemp@phytec.de>

Applied all, thanks

Sascha

> ---
>  drivers/net/phy/micrel.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
> index 8aea653..88c64e5 100644
> --- a/drivers/net/phy/micrel.c
> +++ b/drivers/net/phy/micrel.c
> @@ -254,11 +254,11 @@ static struct phy_driver ksphy_driver[] = {
>  	.config_aneg	= genphy_config_aneg,
>  	.read_status	= genphy_read_status,
>  }, {
> +	/* I saw the same issue like PHY_ID_KSZ9021 for Asym_Pause */
>  	.phy_id		= PHY_ID_KSZ9031,
>  	.phy_id_mask	= 0x00fffff0,
>  	.drv.name	= "Micrel KSZ9031 Gigabit PHY",
> -	.features	= (PHY_GBIT_FEATURES | SUPPORTED_Pause
> -				| SUPPORTED_Asym_Pause),
> +	.features	= (PHY_GBIT_FEATURES | SUPPORTED_Pause),
>  	.config_init	= kszphy_config_init,
>  	.config_aneg	= genphy_config_aneg,
>  	.read_status	= genphy_read_status,
> -- 
> 1.7.0.4
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      parent reply	other threads:[~2014-09-17  6:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-15 12:56 Christian Hemp
2014-09-15 12:56 ` [PATCH 2/4] ARM:phyFLEX-iMX6: Remove eth phy reset form board Christian Hemp
2014-09-15 12:56 ` [PATCH 3/4] ARM:phyFLEX-iMX6: Remove mmd_write_reg from board Christian Hemp
2014-09-15 12:56 ` [PATCH 4/4] ARM:phyFLEX-iMX6 New Ram Timings for Q/DL Christian Hemp
2014-09-17  6:55 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140917065512.GN4992@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=c.hemp@phytec.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox