From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Teresa Gámez" <t.gamez@phytec.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] i2c: omap: fix dts property "clock-frequency" usage
Date: Thu, 2 Oct 2014 07:51:29 +0200 [thread overview]
Message-ID: <20141002055129.GI4992@pengutronix.de> (raw)
In-Reply-To: <1412174236-45854-1-git-send-email-t.gamez@phytec.de>
On Wed, Oct 01, 2014 at 04:37:16PM +0200, Teresa Gámez wrote:
> Looking at the linux kernel the clock-frequency property of
> the device tree is used to set the bus speed and not the
> fclk_rate. Adapted this to be compliant with linux kernel.
>
> Signed-off-by: Teresa Gámez <t.gamez@phytec.de>
Applied, thanks
Sascha
> ---
> drivers/i2c/busses/i2c-omap.c | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
> index adc952b..48bdfbe 100644
> --- a/drivers/i2c/busses/i2c-omap.c
> +++ b/drivers/i2c/busses/i2c-omap.c
> @@ -151,7 +151,6 @@ struct omap_i2c_struct {
> u8 reg_shift;
> struct omap_i2c_driver_data *data;
> struct resource *ioarea;
> - u32 fclk_rate;
> u32 speed; /* Speed of bus in Khz */
> u16 scheme;
> u16 cmd_err;
> @@ -421,7 +420,7 @@ static int omap_i2c_init(struct omap_i2c_struct *i2c_omap)
> internal_clk = 4000;
>
> /* Compute prescaler divisor */
> - psc = i2c_omap->fclk_rate / internal_clk;
> + psc = i2c_data->fclk_rate / internal_clk;
> psc = psc - 1;
>
> /* If configured for High Speed */
> @@ -1016,9 +1015,16 @@ i2c_omap_probe(struct device_d *pdev)
> i2c_omap->reg_shift = (i2c_data->flags >>
> OMAP_I2C_FLAG_BUS_SHIFT__SHIFT) & 3;
>
> - if (pdev->platform_data != NULL)
> + if (pdev->platform_data != NULL) {
> speed = *(u32 *)pdev->platform_data;
> - else
> + } else {
> + of_property_read_u32(pdev->device_node, "clock-frequency",
> + &speed);
> + /* convert DT freq value in Hz into kHz for speed */
> + speed /= 1000;
> + }
> +
> + if (!speed)
> speed = 100; /* Default speed */
>
> i2c_omap->speed = speed;
> @@ -1080,12 +1086,6 @@ i2c_omap_probe(struct device_d *pdev)
> i2c_omap->b_hw = 1; /* Enable hardware fixes */
> }
>
> - i2c_omap->fclk_rate = i2c_data->fclk_rate;
> -
> - if (!i2c_omap->fclk_rate)
> - of_property_read_u32(pdev->device_node, "clock-frequency",
> - &i2c_omap->fclk_rate);
> -
> /* reset ASAP, clearing any IRQs */
> omap_i2c_init(i2c_omap);
>
> --
> 1.9.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2014-10-02 5:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-01 14:37 Teresa Gámez
2014-10-02 5:51 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141002055129.GI4992@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=t.gamez@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox