From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Juergen Borleis <jbe@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/3] mxs: iomux-imx23/imx28: unify mode definition
Date: Fri, 24 Oct 2014 10:19:49 +0200 [thread overview]
Message-ID: <20141024081949.GO8316@pengutronix.de> (raw)
In-Reply-To: <201410240950.21973.jbe@pengutronix.de>
Hello Jürgen,
when going to bed yesterday^Wearlier today I remembered that I wantet do
Cc: you for this series. Great you noticed it anyhow :-)
On Fri, Oct 24, 2014 at 09:50:21AM +0200, Juergen Borleis wrote:
> Hi Uwe,
>
> On Friday 24 October 2014 00:46:00 Uwe Kleine-König wrote:
> > [...]
> > #if defined CONFIG_ARCH_IMX23
> > +/*
> > + * The pin definition of i.MX23 are strange. Bank 0's pins 0 .. 15 are defined
> > + * using PORTF(0, 0) .. PORTF(0, 15). Its pins 16 .. 31 however use PORTF(1, 0)
> > + * .. PORTF(1, 15). So the PORTF macro is more ugly than necessary.
> > + */
> > +# define PORTF(bank,bit) (BANK((bank) / 2) | BANKPIN((((bank) & 1) << 4) | (bit)) | ERROR((bit) & ~15) | ERROR((bank) & ~7)
> > +# define VE_2_5V VOLTAGE(1)
> > # include <mach/iomux-imx23.h>
> > #endif
> > +
>
> Looks more like a strange implementation by myself. Did not remember why I have
> done it in this way...
When Sascha is happy with the changes in this series we can clean that
up.
You didn't test that on an i.MX23 machine, do you?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2014-10-24 8:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-23 22:45 [PATCH 0/3] fixes and sanity checks for mxs pinmuxing Uwe Kleine-König
2014-10-23 22:45 ` [PATCH 1/3] mxs: iomux-imx28: Fix keeper/pullup/drive strength/voltage flags Uwe Kleine-König
2014-10-23 22:46 ` [PATCH 2/3] mxs: iomux-imx23/imx28: unify mode definition Uwe Kleine-König
2014-10-24 7:50 ` Juergen Borleis
2014-10-24 8:19 ` Uwe Kleine-König [this message]
2014-10-24 8:47 ` Juergen Borleis
2014-11-03 12:18 ` Sascha Hauer
2014-10-23 22:46 ` [PATCH 3/3] mxs: iomux-imx23/imx28: add additional checks on mode Uwe Kleine-König
2014-10-24 7:52 ` [PATCH 0/3] fixes and sanity checks for mxs pinmuxing Juergen Borleis
2014-10-27 5:14 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141024081949.GO8316@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=jbe@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox