Re: [For next PATCH 1/3] of: Add of_register_disabled_device functions

[Sascha Hauer <s.hauer@pengutronix.de>]

On Thu, Oct 30, 2014 at 01:02:50PM +0100, Teresa Gámez wrote:
> Function to enable and register a disabled device.
> The devices can be registered using the
> device node with of_register_disabled_device() or
> with the device node name/path by using the
> of_register_disabled_device_by_name() function.
> 
> Signed-off-by: Teresa Gámez <t.gamez@phytec.de>
> ---
>  drivers/of/platform.c | 43 +++++++++++++++++++++++++++++++++++++++++++
>  include/of.h          | 14 ++++++++++++++
>  2 files changed, 57 insertions(+)
> 
> diff --git a/drivers/of/platform.c b/drivers/of/platform.c
> index c417cfd..e4a3042 100644
> --- a/drivers/of/platform.c
> +++ b/drivers/of/platform.c
> @@ -197,6 +197,49 @@ static struct device_d *of_platform_device_create(struct device_node *np,
>  	return NULL;
>  }
>  
> +/**
> + * of_register_disabled_device - Enable and register device
> + * @np: pointer to node to enable create device for
> + *
> + * Returns pointer to created platform device, or NULL if a device was not
> + * registered. Unavailable devices will not get registered.
> + */
> +struct device_d *of_register_disabled_device(struct device_node *np)

We don't register a disabled device, so can we rename this to
of_device_enable_and_register?

> +{
> +	struct device_d *dev;
> +
> +	of_device_enable(np);
> +
> +	dev = of_platform_device_create(np, NULL);
> +	if (!dev)
> +		return NULL;
> +
> +	return dev;
> +}
> +EXPORT_SYMBOL(of_register_disabled_device);
> +
> +/**
> + * of_register_disabled_device - Enable and register device by name
> + * @name: name or path of the device node

The function name is wrong here.

> + *
> + * Returns pointer to created platform device, or NULL if a device was not
> + * registered. Unavailable devices will not get registered.
> + */
> +struct device_d *of_register_disabled_device_by_name(const char *name)

of_device_enable_and_register_by_name

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox