mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] serial: ns16550: Remove unused fields from NS16550_plat structure
Date: Mon, 3 Nov 2014 13:26:01 +0100	[thread overview]
Message-ID: <20141103122601.GF14482@pengutronix.de> (raw)
In-Reply-To: <1414665151-7229-1-git-send-email-shc_work@mail.ru>

Hi Alexander,

On Thu, Oct 30, 2014 at 01:32:31PM +0300, Alexander Shiyan wrote:
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
>  include/ns16550.h | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/include/ns16550.h b/include/ns16550.h
> index 876bb04..ccf950b 100644
> --- a/include/ns16550.h
> +++ b/include/ns16550.h
> @@ -34,9 +34,6 @@ struct NS16550_plat {
>  	/** Clock speed */
>  	unsigned int clock;
>  	int shift;
> -	unsigned int flags;
> -	int mmio;
> -#define NS16650_FLAG_DISABLE_FIFO	1
>  };

This patch removes flags but not its usage in the driver itself.

Squashed this into the commit:


From 668db8bea2c201c3cbdb096cac58287d7b38f396 Mon Sep 17 00:00:00 2001
From: Sascha Hauer <s.hauer@pengutronix.de>
Date: Mon, 3 Nov 2014 13:24:15 +0100
Subject: [PATCH] fixup! serial: ns16550: Remove unused fields from
 NS16550_plat structure

---
 drivers/serial/serial_ns16550.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/serial/serial_ns16550.c b/drivers/serial/serial_ns16550.c
index 4ca7444..53d48a0 100644
--- a/drivers/serial/serial_ns16550.c
+++ b/drivers/serial/serial_ns16550.c
@@ -441,10 +441,7 @@ static int ns16550_probe(struct device_d *dev)
 	cdev->setbrg = ns16550_setbaudrate;
 	cdev->linux_console_name = devtype->linux_console_name;
 
-	if (plat && (plat->flags & NS16650_FLAG_DISABLE_FIFO))
-		priv->fcrval = FCRVAL & ~FCR_FIFO_EN;
-	else
-		priv->fcrval = FCRVAL;
+	priv->fcrval = FCRVAL;
 
 	devtype->init_port(cdev);
 
-- 
2.1.1

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      parent reply	other threads:[~2014-11-03 12:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-30 10:32 Alexander Shiyan
2014-11-03  8:31 ` Sascha Hauer
2014-11-03 12:26 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141103122601.GF14482@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=shc_work@mail.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox