From: Sascha Hauer <s.hauer@pengutronix.de>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] blspec: fix incompatible pointer type warning
Date: Fri, 7 Nov 2014 08:00:40 +0100 [thread overview]
Message-ID: <20141107070040.GX30369@pengutronix.de> (raw)
In-Reply-To: <1415283038-5097-1-git-send-email-l.stach@pengutronix.de>
On Thu, Nov 06, 2014 at 03:10:38PM +0100, Lucas Stach wrote:
> The warning is correct in that we pass in size_t instead
> of int. As we are not interested in the size of the
> property at this point, just remove the assignment.
>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Applied, thanks
Sascha
> ---
> common/blspec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/blspec.c b/common/blspec.c
> index a4adc48da967..f46a11d44c0e 100644
> --- a/common/blspec.c
> +++ b/common/blspec.c
> @@ -294,7 +294,7 @@ static bool entry_is_of_compatible(struct blspec_entry *entry)
> }
>
> pr_info("ignoring entry with incompatible devicetree \"%s\"\n",
> - (char *)of_get_property(root, "compatible", &size));
> + (char *)of_get_property(root, "compatible", NULL));
>
> ret = false;
>
> --
> 2.1.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2014-11-07 7:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-06 14:10 Lucas Stach
2014-11-07 7:00 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141107070040.GX30369@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=l.stach@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox