From: Sascha Hauer <s.hauer@pengutronix.de>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] partitions/efi: Fix off-by-one error in 'last_lba'
Date: Tue, 11 Nov 2014 15:02:53 +0100 [thread overview]
Message-ID: <20141111140253.GV30369@pengutronix.de> (raw)
In-Reply-To: <1415641440-19318-1-git-send-email-andrew.smirnov@gmail.com>
On Mon, Nov 10, 2014 at 09:44:00AM -0800, Andrey Smirnov wrote:
> LBAs are numbered starting from zero so the last LBA # would be equal
> to total number of blocks minus one.
>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Applied, thanks.
> ---
> common/partitions/efi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/common/partitions/efi.c b/common/partitions/efi.c
> index dcb9541..80dc3f3 100644
> --- a/common/partitions/efi.c
> +++ b/common/partitions/efi.c
> @@ -51,11 +51,11 @@ efi_crc32(const void *buf, unsigned long len)
> * the part[0] entry for this disk, and is the number of
> * physical sectors available on the disk.
> */
> -static u64 last_lba(struct block_device *bdev)
> +static u64 last_lba(struct block_device *bdev)
Dropped this hunk while applying.
Sascha
> {
> if (!bdev)
> return 0;
> - return bdev->num_blocks;
> + return bdev->num_blocks - 1;
> }
>
> /**
> --
> 1.9.3
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2014-11-11 14:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-10 17:44 Andrey Smirnov
2014-11-11 14:02 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141111140253.GV30369@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox