[PATCH] partitions/efi: Fix off-by-one error in 'last_lba'

[PATCH] partitions/efi: Fix off-by-one error in 'last_lba'

[Andrey Smirnov]

LBAs are numbered starting from zero so the last LBA # would be equal
to total number of blocks minus one.

Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
 common/partitions/efi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/common/partitions/efi.c b/common/partitions/efi.c
index dcb9541..80dc3f3 100644
--- a/common/partitions/efi.c
+++ b/common/partitions/efi.c
@@ -51,11 +51,11 @@ efi_crc32(const void *buf, unsigned long len)
  *  the part[0] entry for this disk, and is the number of
  *  physical sectors available on the disk.
  */
-static u64 last_lba(struct block_device *bdev)
+static u64  last_lba(struct block_device *bdev)
 {
 	if (!bdev)
 		return 0;
-	return bdev->num_blocks;
+	return bdev->num_blocks - 1;
 }
 
 /**
-- 
1.9.3


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] partitions/efi: Fix off-by-one error in 'last_lba'

[Sascha Hauer]

On Mon, Nov 10, 2014 at 09:44:00AM -0800, Andrey Smirnov wrote:
> LBAs are numbered starting from zero so the last LBA # would be equal
> to total number of blocks minus one.
> 
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>

Applied, thanks.


> ---
>  common/partitions/efi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/common/partitions/efi.c b/common/partitions/efi.c
> index dcb9541..80dc3f3 100644
> --- a/common/partitions/efi.c
> +++ b/common/partitions/efi.c
> @@ -51,11 +51,11 @@ efi_crc32(const void *buf, unsigned long len)
>   *  the part[0] entry for this disk, and is the number of
>   *  physical sectors available on the disk.
>   */
> -static u64 last_lba(struct block_device *bdev)
> +static u64  last_lba(struct block_device *bdev)

Dropped this hunk while applying.

Sascha

>  {
>  	if (!bdev)
>  		return 0;
> -	return bdev->num_blocks;
> +	return bdev->num_blocks - 1;
>  }
>  
>  /**
> -- 
> 1.9.3
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox