From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jan Weitzel <j.weitzel@phytec.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] mtd: ubi: get_bad_peb_limit from mtd master
Date: Thu, 20 Nov 2014 14:53:57 +0100 [thread overview]
Message-ID: <20141120135357.GN30369@pengutronix.de> (raw)
In-Reply-To: <1416408341-31321-1-git-send-email-j.weitzel@phytec.de>
On Wed, Nov 19, 2014 at 03:45:41PM +0100, Jan Weitzel wrote:
> Like mentioned in the coment we need the size of the entire flash chip.
> Check if a master exists and take his size.
>
> Otherwise the limit will be too small and kernel prints:
> UBI warning: print_rsvd_warning: cannot reserve enough PEBs for \
> bad PEB handling, reserved 19, need 20
>
> Signed-off-by: Jan Weitzel <j.weitzel@phytec.de>
Applied, thanks
Sascha
> ---
> drivers/mtd/ubi/build.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/ubi/build.c b/drivers/mtd/ubi/build.c
> index 7b1c332..b02880e 100644
> --- a/drivers/mtd/ubi/build.c
> +++ b/drivers/mtd/ubi/build.c
> @@ -237,7 +237,11 @@ static int get_bad_peb_limit(const struct ubi_device *ubi, int max_beb_per1024)
> * is that all the bad eraseblocks of the chip are in
> * the MTD partition we are attaching (ubi->mtd).
> */
> - device_size = ubi->mtd->size;
> + if (ubi->mtd->master)
> + device_size = ubi->mtd->master->size;
> + else
> + device_size = ubi->mtd->size;
> +
> device_pebs = mtd_div_by_eb(device_size, ubi->mtd);
> limit = mult_frac(device_pebs, max_beb_per1024, 1024);
>
> --
> 1.9.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2014-11-20 13:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-19 14:45 Jan Weitzel
2014-11-20 13:53 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141120135357.GN30369@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=j.weitzel@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox