mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: barebox@lists.infradead.org
Subject: Re: [PATCH 14/14] Kconfig: make BROKEN invisible
Date: Mon, 1 Dec 2014 12:12:19 +0100	[thread overview]
Message-ID: <20141201111219.GH30369@pengutronix.de> (raw)
In-Reply-To: <20141201090043.GL16478@pengutronix.de>

On Mon, Dec 01, 2014 at 10:00:43AM +0100, Michael Olbrich wrote:
> On Fri, Nov 28, 2014 at 03:29:06PM +0100, Sascha Hauer wrote:
> > BROKEN is a developer option to keep things in the tree we know
> > are broken. Make this option invisible so that randconfig builds do
> > not enable it.
> 
> I don't think this is needed. You can specify a partial config file when
> running randconfig with KCONFIG_ALLCONFIG=some_config. Just disable BROKEN
> there.

Not since:

| commit 490f16171119a16e05d670306c105f3b45c38837
| Author: Yann E. MORIN <yann.morin.1998@free.fr>
| Date:   Tue Jun 25 23:37:44 2013 +0200
| 
|     Revert "kconfig: fix randomising choice entries in presence of KCONFIG_ALLCONFIG"
|     
|     This reverts commit 8357b48549e17b3e4e402c7f977b65708922e60f.
|     
|     It breaks more stuff than it fixes.

This renders KCONFIG_ALLCONFIG quite useless.

But regardless of this I think not showing broken options to users is the
right approach.

/me grepping for BROKEN in arch/*/configs/:

arch/arm/configs/friendlyarm_mini6410_defconfig:4:CONFIG_BROKEN=y
arch/arm/configs/freescale-mx28-evk_defconfig:9:CONFIG_BROKEN=y
arch/arm/configs/cfa10036_defconfig:9:CONFIG_BROKEN=y
arch/arm/configs/imx233-olinuxino_defconfig:5:CONFIG_BROKEN=y
arch/arm/configs/friendlyarm_mini2440_defconfig:8:CONFIG_BROKEN=y
arch/arm/configs/freescale-mx23-evk_defconfig:4:CONFIG_BROKEN=y
arch/arm/configs/netx_nxdb500_defconfig:3:CONFIG_BROKEN=y
arch/arm/configs/a9m2410_defconfig:4:CONFIG_BROKEN=y
arch/arm/configs/friendlyarm_tiny6410_defconfig:5:CONFIG_BROKEN=y
arch/arm/configs/chumbyone_defconfig:7:CONFIG_BROKEN=y
arch/arm/configs/a9m2440_defconfig:6:CONFIG_BROKEN=y
arch/arm/configs/tx28stk5_defconfig:8:CONFIG_BROKEN=y
arch/mips/configs/dlink-dir-320_defconfig:5:CONFIG_BROKEN=y
arch/mips/configs/qemu-malta_defconfig:5:CONFIG_BROKEN=y
arch/mips/configs/loongson-ls1b_defconfig:6:CONFIG_BROKEN=y
arch/x86/configs/generic_defconfig:3:CONFIG_BROKEN=y

So users starting from these defconfigs can just enable broken stuff
without even realizing. Let's not bother users with stuff we already
know it's broken.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2014-12-01 11:12 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-28 14:28 [PATCH 01/14] ARM: friendlyarm-mini2440: fix compilation for some displays Sascha Hauer
2014-11-28 14:28 ` [PATCH 02/14] ARM: ep93xx: Fix typo Sascha Hauer
2014-11-28 14:28 ` [PATCH 03/14] ARM: ep93xx: let broken SoCs depend on BROKEN Sascha Hauer
2014-11-28 14:28 ` [PATCH 04/14] ARM: Let MMU depend on !CPU_ARM946E Sascha Hauer
2014-11-28 14:28 ` [PATCH 05/14] ARM: AT91: Always provide clk_set_rate stub Sascha Hauer
2014-11-28 15:23   ` Lucas Stach
2014-11-30 11:01     ` Sascha Hauer
2014-11-28 14:28 ` [PATCH 06/14] mci: mxs-mci: add f_min/f_max fields unconditionally Sascha Hauer
2014-11-28 14:28 ` [PATCH 07/14] param: make string arguments to dev_add_param_fixed const Sascha Hauer
2014-11-28 14:29 ` [PATCH 08/14] fs: bpkfs: select CRC32 Sascha Hauer
2014-11-28 14:29 ` [PATCH 09/14] firmware: altera serial: depend on GENERIC_GPIO Sascha Hauer
2014-11-28 14:29 ` [PATCH 10/14] spi: mxs-spi: Allow compilation on i.MX28 only Sascha Hauer
2014-11-28 14:29 ` [PATCH 11/14] gpio: move gpio_is_valid to include/gpio.h Sascha Hauer
2014-11-28 14:29 ` [PATCH 12/14] ARM: rockchip: select PINCTRL Sascha Hauer
2014-11-28 14:29 ` [PATCH 13/14] ARM: AM335x: Select OFTREE Sascha Hauer
2014-11-28 14:29 ` [PATCH 14/14] Kconfig: make BROKEN invisible Sascha Hauer
2014-12-01  9:00   ` Michael Olbrich
2014-12-01 11:12     ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141201111219.GH30369@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox