From: Antony Pavlov <antonynpavlov@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [RFC] clocksource: dummy: don't show message on first cs read
Date: Mon, 1 Dec 2014 14:01:48 +0400 [thread overview]
Message-ID: <20141201140148.4e8652b784b920d027a6d645@gmail.com> (raw)
In-Reply-To: <20141201063140.GB30369@pengutronix.de>
On Mon, 1 Dec 2014 07:31:40 +0100
Sascha Hauer <s.hauer@pengutronix.de> wrote:
> On Fri, Nov 28, 2014 at 04:07:32PM +0300, Antony Pavlov wrote:
> > In the commit
> >
> > commit 96cae61eba199b9c3f5451f293cf60db2b535164
> > Author: Sascha Hauer <s.hauer@pengutronix.de>
> > Date: Tue Sep 30 08:25:55 2014 +0200
> >
> > clock: Add a variable with the first timestamp after startup
> >
> > For measuring the startup time it's useful to save the first
> > timestamp after the clocksource has been registered.
> >
> > the behaviour of clocksource subsystem is changed: every registered
> > clocksource is called at least once. So the dummy clocksource (if enabled)
> > _ALWAYS_ prints a confusing 'Using dummy clocksource' warning.
> >
> > This patch fixes the situation: now the 'Using dummy clocksource'
> > warning is printed only if the dummy clocksource is called second time.
>
> I don't like this very much. The dummy clocksource expects some certain
> behaviour of the common clocksource code and works around this when it
> changes. How about integrating the dummy clocksource into the core
> instead, like
>
> uint64_t get_time_ns(void)
> {
> if (!current_clock)
> return dummy_counter++;
>
> ...
> }
>
> Then add a initcall which warns later if we still don't have a valid
> clocksource?
Good plan! I'll try to realize it in several days.
--
Best regards,
Antony Pavlov
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2014-12-01 10:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-28 13:07 Antony Pavlov
2014-12-01 6:31 ` Sascha Hauer
2014-12-01 10:01 ` Antony Pavlov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141201140148.4e8652b784b920d027a6d645@gmail.com \
--to=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox