From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Teresa Gámez" <t.gamez@phytec.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/3] ARM: dts: am335x-phytec-phyflex: Increase kernel partition on SPI NOR
Date: Tue, 9 Dec 2014 11:52:26 +0100 [thread overview]
Message-ID: <20141209105226.GW30369@pengutronix.de> (raw)
In-Reply-To: <1418120207.5704.8.camel@lws-gamez.phytec.de>
On Tue, Dec 09, 2014 at 11:16:47AM +0100, Teresa Gámez wrote:
> Hello Sascha,
>
> Am Dienstag, den 09.12.2014, 10:13 +0100 schrieb Sascha Hauer:
> > Hi Teresa,
> >
> > On Mon, Dec 08, 2014 at 10:59:49AM +0100, Teresa Gámez wrote:
> > > Increase kernel partition to end of SPI NOR.
> > >
> > > Signed-off-by: Teresa Gámez <t.gamez@phytec.de>
> > > ---
> > > arch/arm/dts/am335x-phytec-phyflex.dts | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/arch/arm/dts/am335x-phytec-phyflex.dts b/arch/arm/dts/am335x-phytec-phyflex.dts
> > > index c4481f5..0de7e87 100644
> > > --- a/arch/arm/dts/am335x-phytec-phyflex.dts
> > > +++ b/arch/arm/dts/am335x-phytec-phyflex.dts
> > > @@ -187,7 +187,7 @@
> > >
> > > partition@4 {
> > > label = "kernel";
> > > - reg = <0xe0000 0x400000>;
> > > + reg = <0xe0000 0x0>;
> > > };
> >
> > I wasn't aware barebox handles this case like you intend here. What
> > about the kernel? Won't you end up with a zero sized partition there?
>
> have a look at include/linux/mtd/partitions.h in the linux kernel.
>
> There is a macro defined
> #define MTDPART_SIZ_FULL (0)
>
> And the comment above says:
> size: the partition size; if defined as MTDPART_SIZ_FULL, the partition
> will extend to the end of the master MTD device.
>
> This works fine for kernel and barebox.
Oh nice, didn't know that. In this case consider your patches applied.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2014-12-09 10:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-08 9:59 Teresa Gámez
2014-12-08 9:59 ` [PATCH 2/3] ARM: dts: am335x-phytec-phycore-som: " Teresa Gámez
2014-12-08 9:59 ` [PATCH 3/3] ARM: phytec: am335x: Update enviroment comment Teresa Gámez
2014-12-09 9:13 ` [PATCH 1/3] ARM: dts: am335x-phytec-phyflex: Increase kernel partition on SPI NOR Sascha Hauer
2014-12-09 10:16 ` Teresa Gámez
2014-12-09 10:52 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141209105226.GW30369@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=t.gamez@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox