mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH 1/3] arm: include relevant headers in barebox-arm
@ 2014-12-17 10:58 Lucas Stach
  2014-12-17 10:58 ` [PATCH 2/3] arm: edmqmx6: build entry in lwl target Lucas Stach
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Lucas Stach @ 2014-12-17 10:58 UTC (permalink / raw)
  To: barebox

Provide the necessary types and defines used in this header.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 arch/arm/include/asm/barebox-arm.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/include/asm/barebox-arm.h b/arch/arm/include/asm/barebox-arm.h
index 66f6fe5ef6b4..641c00f81848 100644
--- a/arch/arm/include/asm/barebox-arm.h
+++ b/arch/arm/include/asm/barebox-arm.h
@@ -27,6 +27,8 @@
 
 #include <sizes.h>
 #include <asm-generic/memory_layout.h>
+#include <linux/kernel.h>
+#include <linux/types.h>
 
 /* cpu/.../cpu.c */
 int	cleanup_before_linux(void);
-- 
2.1.3


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 2/3] arm: edmqmx6: build entry in lwl target
  2014-12-17 10:58 [PATCH 1/3] arm: include relevant headers in barebox-arm Lucas Stach
@ 2014-12-17 10:58 ` Lucas Stach
  2014-12-17 10:58 ` [PATCH 3/3] arm: do section garbage collection also with modules enabled Lucas Stach
  2014-12-17 12:47 ` [PATCH 1/3] arm: include relevant headers in barebox-arm Sascha Hauer
  2 siblings, 0 replies; 4+ messages in thread
From: Lucas Stach @ 2014-12-17 10:58 UTC (permalink / raw)
  To: barebox

Only build it at the correct obj or pbl stage where
the entry is needed.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 arch/arm/boards/datamodul-edm-qmx6/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boards/datamodul-edm-qmx6/Makefile b/arch/arm/boards/datamodul-edm-qmx6/Makefile
index bb6d9d848d4f..01c7a259e9a5 100644
--- a/arch/arm/boards/datamodul-edm-qmx6/Makefile
+++ b/arch/arm/boards/datamodul-edm-qmx6/Makefile
@@ -1,2 +1,2 @@
-obj-y += board.o lowlevel.o
-pbl-y += lowlevel.o
+obj-y += board.o
+lwl-y += lowlevel.o
-- 
2.1.3


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 3/3] arm: do section garbage collection also with modules enabled
  2014-12-17 10:58 [PATCH 1/3] arm: include relevant headers in barebox-arm Lucas Stach
  2014-12-17 10:58 ` [PATCH 2/3] arm: edmqmx6: build entry in lwl target Lucas Stach
@ 2014-12-17 10:58 ` Lucas Stach
  2014-12-17 12:47 ` [PATCH 1/3] arm: include relevant headers in barebox-arm Sascha Hauer
  2 siblings, 0 replies; 4+ messages in thread
From: Lucas Stach @ 2014-12-17 10:58 UTC (permalink / raw)
  To: barebox

A lot of the arm build (especially PBL stuff) depends on section
garbage collection to be enabled. If it is disabled a lot of targets fail
to link properly. If module support is enabled garbage collection was
disabled on the premise that we throw away too many function which may be
needed in later modules.

The proper way to keep the functions around for use in modules, which
already works, is to annotate them with EXPORT_SYMBOL.

As module support is still marked as experimental I think it's reasonable
to expect users to make sure all symbols that are used by their modules
are properly annotated.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 arch/arm/Makefile | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm/Makefile b/arch/arm/Makefile
index cf81c9c08332..193f731e9039 100644
--- a/arch/arm/Makefile
+++ b/arch/arm/Makefile
@@ -105,11 +105,9 @@ TEXT_BASE = $(CONFIG_TEXT_BASE)
 
 CPPFLAGS += -DTEXT_BASE=$(TEXT_BASE)
 
-ifndef CONFIG_MODULES
 # Add cleanup flags
 CPPFLAGS += -fdata-sections -ffunction-sections
 LDFLAGS_barebox += -static --gc-sections
-endif
 
 ifdef CONFIG_RELOCATABLE
 LDFLAGS_barebox += -pie
-- 
2.1.3


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/3] arm: include relevant headers in barebox-arm
  2014-12-17 10:58 [PATCH 1/3] arm: include relevant headers in barebox-arm Lucas Stach
  2014-12-17 10:58 ` [PATCH 2/3] arm: edmqmx6: build entry in lwl target Lucas Stach
  2014-12-17 10:58 ` [PATCH 3/3] arm: do section garbage collection also with modules enabled Lucas Stach
@ 2014-12-17 12:47 ` Sascha Hauer
  2 siblings, 0 replies; 4+ messages in thread
From: Sascha Hauer @ 2014-12-17 12:47 UTC (permalink / raw)
  To: Lucas Stach; +Cc: barebox

On Wed, Dec 17, 2014 at 11:58:19AM +0100, Lucas Stach wrote:
> Provide the necessary types and defines used in this header.
> 
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
>  arch/arm/include/asm/barebox-arm.h | 2 ++
>  1 file changed, 2 insertions(+)

Applied all, thanks

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-12-17 12:48 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-17 10:58 [PATCH 1/3] arm: include relevant headers in barebox-arm Lucas Stach
2014-12-17 10:58 ` [PATCH 2/3] arm: edmqmx6: build entry in lwl target Lucas Stach
2014-12-17 10:58 ` [PATCH 3/3] arm: do section garbage collection also with modules enabled Lucas Stach
2014-12-17 12:47 ` [PATCH 1/3] arm: include relevant headers in barebox-arm Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox