From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: victorien <victorien.vedrine@ophrys.net>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] partitions: dos: Fix support of extended partition type 0x05
Date: Fri, 19 Dec 2014 19:59:01 +0100 [thread overview]
Message-ID: <20141219185901.GG10857@pengutronix.de> (raw)
In-Reply-To: <1418832597-3932-1-git-send-email-victorien.vedrine@ophrys.net>
Hallo,
On Wed, Dec 17, 2014 at 05:09:57PM +0100, victorien wrote:
> ---
> common/partitions/dos.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/partitions/dos.c b/common/partitions/dos.c
> index 37addfd..8a3c5c3 100644
> --- a/common/partitions/dos.c
> +++ b/common/partitions/dos.c
> @@ -209,7 +209,7 @@ static void dos_partition(void *buf, struct block_device *blk,
> * here as this is the easiest to parse and common
> * enough.
> */
> - if (pentry.dos_partition_type == 0x0f) {
> + if ((pentry.dos_partition_type == 0x0f)||(pentry.dos_partition_type == 0x05)) {
apart from what Sascha said, also add spaces around ||. Also break lines
at or before column 80 (with tabs accounting for 8 columns).
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2014-12-19 18:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-17 16:09 victorien
2014-12-19 6:52 ` Sascha Hauer
2014-12-19 9:14 ` Victorien Vedrine
2014-12-19 18:59 ` Uwe Kleine-König [this message]
2014-12-22 8:50 ` Victorien Vedrine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141219185901.GG10857@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=victorien.vedrine@ophrys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox