From: Sascha Hauer <s.hauer@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [RFC] introduce ioremap() and dev_ioremap_resource()
Date: Sat, 20 Dec 2014 08:05:42 +0100 [thread overview]
Message-ID: <20141220070542.GC30369@pengutronix.de> (raw)
In-Reply-To: <20141219171219.b672ff943c851cbe6adf5006@gmail.com>
On Fri, Dec 19, 2014 at 05:12:19PM +0400, Antony Pavlov wrote:
> On Fri, 19 Dec 2014 07:45:42 +0100
> > > moreover dev_ioremap_resource() has the second 'struct resource *res'
> > > argument, so additional dev_get_resource() is needed.
> > >
> > > Can we insert ioremap() into dev_request_mem_region() directly?
> > > (we also can use already existion IOMEM() macro instead of linux' ioremap()).
> >
> > I'm not sure if it's a good idea to put that behind some standard
> > lookingioremap() call, because its behaviour is not standard.
> >
> > I'm also fine with adding some
> >
> > #ifdef CONFIG_MIPS
> > return mips_iomem(res->start);
> > #else
> > return (void __force __iomem *)res->start;
> > #endif
> >
> > At least this makes explicit that MIPS has a very special handling.
>
> We already have this in include/common.h
>
> #if defined(CONFIG_MIPS)
> #include <asm/addrspace.h>
>
> #define IOMEM(addr) ((void __force __iomem *)CKSEG1ADDR(addr))
> #else
> #define IOMEM(addr) ((void __force __iomem *)(addr))
> #endif
>
> So can I use just
>
> return IOMEM(res->start);
>
> in dev_request_mem_region()?
Yes, nice. That's the right solution then.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2014-12-20 7:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-18 22:32 Antony Pavlov
2014-12-19 6:45 ` Sascha Hauer
2014-12-19 13:12 ` Antony Pavlov
2014-12-20 7:05 ` Sascha Hauer [this message]
2015-01-08 17:23 ` Antony Pavlov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141220070542.GC30369@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox