From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 6/9] console: factorize kfifo input support
Date: Mon, 5 Jan 2015 12:18:45 +0100 [thread overview]
Message-ID: <20150105111845.GQ30369@pengutronix.de> (raw)
In-Reply-To: <1419358918-25569-6-git-send-email-plagnioj@jcrosoft.com>
On Tue, Dec 23, 2014 at 07:21:55PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> handle input fifo at console framework level instead of driver
>
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> ---
> common/Kconfig | 3 ++
> common/console.c | 8 +++++
> common/console_common.c | 71 ++++++++++++++++++++++++++++++++++++++++++
> common/console_simple.c | 4 +++
> drivers/input/Kconfig | 4 +++
> drivers/input/gpio_keys.c | 43 ++++---------------------
> drivers/input/imx_keypad.c | 29 ++---------------
> drivers/input/qt1070.c | 28 ++---------------
> drivers/input/twl6030_pwrbtn.c | 32 ++-----------------
> include/console.h | 22 +++++++++++++
> include/gpio_keys.h | 1 -
> 11 files changed, 124 insertions(+), 121 deletions(-)
Instead of integrating this into the core code can we make this a helper
function? Something like:
struct console_poller {
struct poller poller;
struct kfifo fifo;
struct console_device *cdev;
int (*tstc)(struct console_device *cdev)
int (*getc)(struct console_device *cdev)
};
int console_init_input_fifo(struct console_poller *copo)
{
if (!copo->cdev || !copo->getc || !copo->tstc)
return -EINVAL;
copo->cdev->tstc = console_fifo_tstc;
copo->cdev->getc = console_fifo_getc;
/* init kfifo / poller */
return 0;
}
...
struct gpio_keys {
...
struct console_poller copo;
...
};
static int __init gpio_keys_probe(struct device_d *dev)
{
...
gk->copo.getc = gpio_keys_getc;
gk->copo.tstc = gpio_keys_tstc;
console_init_input_fifo(&gk->copo);
}
That would make the Kconfig option unnecessary and the core wouldn't get
more complicated.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2015-01-05 11:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-23 17:07 [PATCH 0/9] versatilepb, console, graphichs serie Jean-Christophe PLAGNIOL-VILLARD
2014-12-23 18:21 ` [PATCH 1/9] kfifo: allow to pass a null point on kfifo_free Jean-Christophe PLAGNIOL-VILLARD
2014-12-23 18:21 ` [PATCH 2/9] efika-mx-smartbook: enable led hearbeat on mail Jean-Christophe PLAGNIOL-VILLARD
2015-01-05 10:36 ` Sascha Hauer
2014-12-23 18:21 ` [PATCH 3/9] grapric_utils: set_pixel only write 16bit in 16bit mode Jean-Christophe PLAGNIOL-VILLARD
2015-01-05 10:37 ` Sascha Hauer
2014-12-23 18:21 ` [PATCH 4/9] versatilepb: move barebox to 32 MiB and use zImage Jean-Christophe PLAGNIOL-VILLARD
2015-01-05 10:38 ` Sascha Hauer
2014-12-23 18:21 ` [PATCH 5/9] versatilepb: switch to defaultenv-2 Jean-Christophe PLAGNIOL-VILLARD
2015-01-05 10:38 ` Sascha Hauer
2014-12-23 18:21 ` [PATCH 6/9] console: factorize kfifo input support Jean-Christophe PLAGNIOL-VILLARD
2015-01-05 11:18 ` Sascha Hauer [this message]
2014-12-23 18:21 ` [PATCH 7/9] poller: allow to restrict the poller frequency Jean-Christophe PLAGNIOL-VILLARD
2015-01-05 10:42 ` Sascha Hauer
2015-01-06 0:46 ` Jean-Christophe PLAGNIOL-VILLARD
2014-12-23 18:21 ` [PATCH 8/9] console: allow to specify the device id Jean-Christophe PLAGNIOL-VILLARD
2015-01-05 10:46 ` Sascha Hauer
2014-12-23 18:21 ` [PATCH 9/9] defaultenv-2: create a specific defaultenv for splash Jean-Christophe PLAGNIOL-VILLARD
2015-01-05 10:50 ` Sascha Hauer
2015-01-06 0:43 ` Jean-Christophe PLAGNIOL-VILLARD
2015-01-06 12:57 ` Sascha Hauer
2015-01-07 5:49 ` Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150105111845.GQ30369@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox