From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Teresa Gámez" <t.gamez@phytec.de>
Cc: ledphilippe@gmail.com, barebox@lists.infradead.org
Subject: Re: [PATCH] net: cpsw: Fix crashes on beaglebone black
Date: Tue, 6 Jan 2015 15:16:48 +0100 [thread overview]
Message-ID: <20150106141648.GI17225@pengutronix.de> (raw)
In-Reply-To: <1420461321.6731.34.camel@lws-gamez.phytec.de>
On Mon, Jan 05, 2015 at 01:35:21PM +0100, Teresa Gámez wrote:
> Hello Philippe,
>
> >
> > [<9fe32349>] (unwind_backtrace+0x1/0x58) from [<9fe258e9>] (panic+0x1d/0x34)
> > [<9fe258e9>] (panic+0x1d/0x34) from [<9fe327e1>] (do_exception+0xd/0x10)
> > [<9fe327e1>] (do_exception+0xd/0x10) from [<9fe32849>]
> > (do_data_abort+0x21/0x2c)
> > [<9fe32849>] (do_data_abort+0x21/0x2c) from [<9fe32508>]
> > (data_abort+0x48/0x60)
> >
> >
>
> I suspect the issue comes from the dummy cpsw_emac1 node which adds a
> non existing phy in the beaglebone device tree. So the mdiobus_scan
> fails. This patch will workaround the issue but I'm unsure about right
> solution here.
You are right, this is not the ideal solution. Nevertheless I just sent
out a similar patch. It should be good enough for now.
In the longer run the phy shouldn't be probed for in the devices probe
function. There also should be a way to disable a slave in the device
tree, right now both slaves are defined in the dtsi file and a status =
"disabled" is ignored (Does this work in the kernel?).
Also the cpsw driver should accept a proper phy binding. The official
agreed-upon binding is phy-handle = <ðphy>, not phy_id = <&miibus>,
<0>. The driver should at least optionally support this.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2015-01-06 14:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-27 14:39 ledphilippe
2015-01-05 12:35 ` Teresa Gámez
2015-01-06 14:16 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150106141648.GI17225@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=ledphilippe@gmail.com \
--cc=t.gamez@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox