mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Masahiro Yamada <yamada.m@jp.panasonic.com>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] kbuild: add KBUILD_DEFCONFIG
Date: Tue, 13 Jan 2015 16:54:47 +0900	[thread overview]
Message-ID: <20150113165447.CACE.AA925319@jp.panasonic.com> (raw)
In-Reply-To: <29573FD6-1527-4C63-ACBE-85847B0F1277@jcrosoft.com>

Hi Jean-Christophe,

On Tue, 13 Jan 2015 14:53:19 +0800
Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> wrote:

> 
> > On Jan 13, 2015, at 2:46 PM, Masahiro Yamada <yamada.m@jp.panasonic.com> wrote:
> > 
> > This allows "make ARCH=... defconfig".
> > 
> > Fox example, you can type "make defconfig" instead of
> > "make sandbox_defconfig".
> > 
> > Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> > ---
> > 
> > arch/arm/Makefile      | 1 +
> > arch/blackfin/Makefile | 1 +
> > arch/efi/Makefile      | 2 ++
> > arch/nios2/Makefile    | 2 ++
> > arch/openrisc/Makefile | 2 ++
> > arch/sandbox/Makefile  | 1 +
> > arch/x86/Makefile      | 2 ++
> > 7 files changed, 11 insertions(+)
> > 
> > diff --git a/arch/arm/Makefile b/arch/arm/Makefile
> > index f06e2a0..9dd983b 100644
> > --- a/arch/arm/Makefile
> > +++ b/arch/arm/Makefile
> > @@ -1,3 +1,4 @@
> > +KBUILD_DEFCONFIG := versatilepb_defconfig
> 
> no sure we need a default config on arm and some other
> 
> I known we use them on the kernel but here it could result in a broken board
> if use not carefully
> 
> for arch that only have 1 defconfig and will only have one maybe
> 

Why could it result in a broken board?  (It seems harmless to me.)

I think it is useful at least for Sandbox and some other arches that
have only "generic_defconfig".

It is true that KBUILD_DEFCONFIG is not so useful for ARM.
If it is not desired for ARM (and Blackfin), we can drop it, of course.



Best Regards
Masahiro Yamada


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2015-01-13  7:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-13  6:46 Masahiro Yamada
2015-01-13  6:53 ` Jean-Christophe PLAGNIOL-VILLARD
2015-01-13  7:54   ` Masahiro Yamada [this message]
2015-01-13  8:02     ` Sascha Hauer
2015-01-13  8:16       ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150113165447.CACE.AA925319@jp.panasonic.com \
    --to=yamada.m@jp.panasonic.com \
    --cc=barebox@lists.infradead.org \
    --cc=plagnioj@jcrosoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox