[PATCH] kbuild: add KBUILD_DEFCONFIG

[PATCH] kbuild: add KBUILD_DEFCONFIG

[Masahiro Yamada]

This allows "make ARCH=... defconfig".

Fox example, you can type "make defconfig" instead of
"make sandbox_defconfig".

Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
---

 arch/arm/Makefile      | 1 +
 arch/blackfin/Makefile | 1 +
 arch/efi/Makefile      | 2 ++
 arch/nios2/Makefile    | 2 ++
 arch/openrisc/Makefile | 2 ++
 arch/sandbox/Makefile  | 1 +
 arch/x86/Makefile      | 2 ++
 7 files changed, 11 insertions(+)

diff --git a/arch/arm/Makefile b/arch/arm/Makefile
index f06e2a0..9dd983b 100644
--- a/arch/arm/Makefile
+++ b/arch/arm/Makefile
@@ -1,3 +1,4 @@
+KBUILD_DEFCONFIG := versatilepb_defconfig
 
 CPPFLAGS	+= -D__ARM__ -fno-strict-aliasing
 # Explicitly specifiy 32-bit ARM ISA since toolchain default can be -mthumb:
diff --git a/arch/blackfin/Makefile b/arch/blackfin/Makefile
index 381c6a9..5c43bf7 100644
--- a/arch/blackfin/Makefile
+++ b/arch/blackfin/Makefile
@@ -1,3 +1,4 @@
+KBUILD_DEFCONFIG := ipe337_defconfig
 
 CPPFLAGS += -fno-strict-aliasing
 
diff --git a/arch/efi/Makefile b/arch/efi/Makefile
index 85cb655..b078bd0 100644
--- a/arch/efi/Makefile
+++ b/arch/efi/Makefile
@@ -1,3 +1,5 @@
+KBUILD_DEFCONFIG := efi_defconfig
+
 CFLAGS += -fpic -fshort-wchar -mno-sse -mno-mmx
 
 ifeq ($(CONFIG_X86_32),y)
diff --git a/arch/nios2/Makefile b/arch/nios2/Makefile
index 681944f..d079190 100644
--- a/arch/nios2/Makefile
+++ b/arch/nios2/Makefile
@@ -1,3 +1,5 @@
+KBUILD_DEFCONFIG := generic_defconfig
+
 CPPFLAGS += -fno-strict-aliasing -mno-hw-mul
 
 board-$(CONFIG_GENERIC) := generic
diff --git a/arch/openrisc/Makefile b/arch/openrisc/Makefile
index b0c8566..5394afb 100644
--- a/arch/openrisc/Makefile
+++ b/arch/openrisc/Makefile
@@ -1,3 +1,5 @@
+KBUILD_DEFCONFIG := generic_defconfig
+
 CPPFLAGS += -D__OR1K__ -ffixed-r10 -mhard-mul -mhard-div
 
 board-$(CONFIG_GENERIC) := generic
diff --git a/arch/sandbox/Makefile b/arch/sandbox/Makefile
index ed5d3a3..e3fb039 100644
--- a/arch/sandbox/Makefile
+++ b/arch/sandbox/Makefile
@@ -1,3 +1,4 @@
+KBUILD_DEFCONFIG := sandbox_defconfig
 
 CPPFLAGS += -D__SANDBOX__ -fno-strict-aliasing
 
diff --git a/arch/x86/Makefile b/arch/x86/Makefile
index a78fa22..da17d70 100644
--- a/arch/x86/Makefile
+++ b/arch/x86/Makefile
@@ -1,3 +1,5 @@
+KBUILD_DEFCONFIG := generic_defconfig
+
 CPPFLAGS += -D__X86__ -fno-strict-aliasing
 
 board-y := x86_generic
-- 
1.9.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] kbuild: add KBUILD_DEFCONFIG

[Jean-Christophe PLAGNIOL-VILLARD]

> On Jan 13, 2015, at 2:46 PM, Masahiro Yamada <yamada.m@jp.panasonic.com> wrote:
> 
> This allows "make ARCH=... defconfig".
> 
> Fox example, you can type "make defconfig" instead of
> "make sandbox_defconfig".
> 
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> ---
> 
> arch/arm/Makefile      | 1 +
> arch/blackfin/Makefile | 1 +
> arch/efi/Makefile      | 2 ++
> arch/nios2/Makefile    | 2 ++
> arch/openrisc/Makefile | 2 ++
> arch/sandbox/Makefile  | 1 +
> arch/x86/Makefile      | 2 ++
> 7 files changed, 11 insertions(+)
> 
> diff --git a/arch/arm/Makefile b/arch/arm/Makefile
> index f06e2a0..9dd983b 100644
> --- a/arch/arm/Makefile
> +++ b/arch/arm/Makefile
> @@ -1,3 +1,4 @@
> +KBUILD_DEFCONFIG := versatilepb_defconfig

no sure we need a default config on arm and some other

I known we use them on the kernel but here it could result in a broken board
if use not carefully

for arch that only have 1 defconfig and will only have one maybe

Best Regards,
J.
> 
> CPPFLAGS	+= -D__ARM__ -fno-strict-aliasing
> # Explicitly specifiy 32-bit ARM ISA since toolchain default can be -mthumb:
> diff --git a/arch/blackfin/Makefile b/arch/blackfin/Makefile
> index 381c6a9..5c43bf7 100644
> --- a/arch/blackfin/Makefile
> +++ b/arch/blackfin/Makefile
> @@ -1,3 +1,4 @@
> +KBUILD_DEFCONFIG := ipe337_defconfig
> 
> CPPFLAGS += -fno-strict-aliasing
> 
> diff --git a/arch/efi/Makefile b/arch/efi/Makefile
> index 85cb655..b078bd0 100644
> --- a/arch/efi/Makefile
> +++ b/arch/efi/Makefile
> @@ -1,3 +1,5 @@
> +KBUILD_DEFCONFIG := efi_defconfig
> +
> CFLAGS += -fpic -fshort-wchar -mno-sse -mno-mmx
> 
> ifeq ($(CONFIG_X86_32),y)
> diff --git a/arch/nios2/Makefile b/arch/nios2/Makefile
> index 681944f..d079190 100644
> --- a/arch/nios2/Makefile
> +++ b/arch/nios2/Makefile
> @@ -1,3 +1,5 @@
> +KBUILD_DEFCONFIG := generic_defconfig
> +
> CPPFLAGS += -fno-strict-aliasing -mno-hw-mul
> 
> board-$(CONFIG_GENERIC) := generic
> diff --git a/arch/openrisc/Makefile b/arch/openrisc/Makefile
> index b0c8566..5394afb 100644
> --- a/arch/openrisc/Makefile
> +++ b/arch/openrisc/Makefile
> @@ -1,3 +1,5 @@
> +KBUILD_DEFCONFIG := generic_defconfig
> +
> CPPFLAGS += -D__OR1K__ -ffixed-r10 -mhard-mul -mhard-div
> 
> board-$(CONFIG_GENERIC) := generic
> diff --git a/arch/sandbox/Makefile b/arch/sandbox/Makefile
> index ed5d3a3..e3fb039 100644
> --- a/arch/sandbox/Makefile
> +++ b/arch/sandbox/Makefile
> @@ -1,3 +1,4 @@
> +KBUILD_DEFCONFIG := sandbox_defconfig
> 
> CPPFLAGS += -D__SANDBOX__ -fno-strict-aliasing
> 
> diff --git a/arch/x86/Makefile b/arch/x86/Makefile
> index a78fa22..da17d70 100644
> --- a/arch/x86/Makefile
> +++ b/arch/x86/Makefile
> @@ -1,3 +1,5 @@
> +KBUILD_DEFCONFIG := generic_defconfig
> +
> CPPFLAGS += -D__X86__ -fno-strict-aliasing
> 
> board-y := x86_generic
> -- 
> 1.9.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] kbuild: add KBUILD_DEFCONFIG

[Masahiro Yamada]

Hi Jean-Christophe,

On Tue, 13 Jan 2015 14:53:19 +0800
Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> wrote:

> 
> > On Jan 13, 2015, at 2:46 PM, Masahiro Yamada <yamada.m@jp.panasonic.com> wrote:
> > 
> > This allows "make ARCH=... defconfig".
> > 
> > Fox example, you can type "make defconfig" instead of
> > "make sandbox_defconfig".
> > 
> > Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> > ---
> > 
> > arch/arm/Makefile      | 1 +
> > arch/blackfin/Makefile | 1 +
> > arch/efi/Makefile      | 2 ++
> > arch/nios2/Makefile    | 2 ++
> > arch/openrisc/Makefile | 2 ++
> > arch/sandbox/Makefile  | 1 +
> > arch/x86/Makefile      | 2 ++
> > 7 files changed, 11 insertions(+)
> > 
> > diff --git a/arch/arm/Makefile b/arch/arm/Makefile
> > index f06e2a0..9dd983b 100644
> > --- a/arch/arm/Makefile
> > +++ b/arch/arm/Makefile
> > @@ -1,3 +1,4 @@
> > +KBUILD_DEFCONFIG := versatilepb_defconfig
> 
> no sure we need a default config on arm and some other
> 
> I known we use them on the kernel but here it could result in a broken board
> if use not carefully
> 
> for arch that only have 1 defconfig and will only have one maybe
> 

Why could it result in a broken board?  (It seems harmless to me.)

I think it is useful at least for Sandbox and some other arches that
have only "generic_defconfig".

It is true that KBUILD_DEFCONFIG is not so useful for ARM.
If it is not desired for ARM (and Blackfin), we can drop it, of course.



Best Regards
Masahiro Yamada


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] kbuild: add KBUILD_DEFCONFIG

[Sascha Hauer]

On Tue, Jan 13, 2015 at 04:54:47PM +0900, Masahiro Yamada wrote:
> Hi Jean-Christophe,
> 
> On Tue, 13 Jan 2015 14:53:19 +0800
> Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> wrote:
> 
> > 
> > > On Jan 13, 2015, at 2:46 PM, Masahiro Yamada <yamada.m@jp.panasonic.com> wrote:
> > > 
> > > This allows "make ARCH=... defconfig".
> > > 
> > > Fox example, you can type "make defconfig" instead of
> > > "make sandbox_defconfig".
> > > 
> > > Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> > > ---
> > > 
> > > arch/arm/Makefile      | 1 +
> > > arch/blackfin/Makefile | 1 +
> > > arch/efi/Makefile      | 2 ++
> > > arch/nios2/Makefile    | 2 ++
> > > arch/openrisc/Makefile | 2 ++
> > > arch/sandbox/Makefile  | 1 +
> > > arch/x86/Makefile      | 2 ++
> > > 7 files changed, 11 insertions(+)
> > > 
> > > diff --git a/arch/arm/Makefile b/arch/arm/Makefile
> > > index f06e2a0..9dd983b 100644
> > > --- a/arch/arm/Makefile
> > > +++ b/arch/arm/Makefile
> > > @@ -1,3 +1,4 @@
> > > +KBUILD_DEFCONFIG := versatilepb_defconfig
> > 
> > no sure we need a default config on arm and some other
> > 
> > I known we use them on the kernel but here it could result in a broken board
> > if use not carefully
> > 
> > for arch that only have 1 defconfig and will only have one maybe
> > 
> 
> Why could it result in a broken board?  (It seems harmless to me.)
> 
> I think it is useful at least for Sandbox and some other arches that
> have only "generic_defconfig".
> 
> It is true that KBUILD_DEFCONFIG is not so useful for ARM.
> If it is not desired for ARM (and Blackfin), we can drop it, of course.

I think it makes sense on EFI, x86 and sandbox. On the other
architectures one must know which board to build, so let's do not
get others the impression that the generic defconfig produces something
useful. This also includes nios2 and openrisc. For these two only
one defconfig exists but I think this is more because these
architectures have very limited usage.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] kbuild: add KBUILD_DEFCONFIG

[Masahiro Yamada]

On Tue, 13 Jan 2015 09:02:58 +0100
Sascha Hauer <s.hauer@pengutronix.de> wrote:

> On Tue, Jan 13, 2015 at 04:54:47PM +0900, Masahiro Yamada wrote:
> > Hi Jean-Christophe,
> > 
> > On Tue, 13 Jan 2015 14:53:19 +0800
> > Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> wrote:
> > 
> > > 
> > > > On Jan 13, 2015, at 2:46 PM, Masahiro Yamada <yamada.m@jp.panasonic.com> wrote:
> > > > 
> > > > This allows "make ARCH=... defconfig".
> > > > 
> > > > Fox example, you can type "make defconfig" instead of
> > > > "make sandbox_defconfig".
> > > > 
> > > > Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> > > > ---
> > > > 
> > > > arch/arm/Makefile      | 1 +
> > > > arch/blackfin/Makefile | 1 +
> > > > arch/efi/Makefile      | 2 ++
> > > > arch/nios2/Makefile    | 2 ++
> > > > arch/openrisc/Makefile | 2 ++
> > > > arch/sandbox/Makefile  | 1 +
> > > > arch/x86/Makefile      | 2 ++
> > > > 7 files changed, 11 insertions(+)
> > > > 
> > > > diff --git a/arch/arm/Makefile b/arch/arm/Makefile
> > > > index f06e2a0..9dd983b 100644
> > > > --- a/arch/arm/Makefile
> > > > +++ b/arch/arm/Makefile
> > > > @@ -1,3 +1,4 @@
> > > > +KBUILD_DEFCONFIG := versatilepb_defconfig
> > > 
> > > no sure we need a default config on arm and some other
> > > 
> > > I known we use them on the kernel but here it could result in a broken board
> > > if use not carefully
> > > 
> > > for arch that only have 1 defconfig and will only have one maybe
> > > 
> > 
> > Why could it result in a broken board?  (It seems harmless to me.)
> > 
> > I think it is useful at least for Sandbox and some other arches that
> > have only "generic_defconfig".
> > 
> > It is true that KBUILD_DEFCONFIG is not so useful for ARM.
> > If it is not desired for ARM (and Blackfin), we can drop it, of course.
> 
> I think it makes sense on EFI, x86 and sandbox. On the other
> architectures one must know which board to build, so let's do not
> get others the impression that the generic defconfig produces something
> useful. This also includes nios2 and openrisc. For these two only
> one defconfig exists but I think this is more because these
> architectures have very limited usage.
> 

OK, I have posted v2 where only EFI, x86 and sandbox is changed.

Best Regards
Masahiro Yamada



_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox