From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Bo Shen <voice.shen@atmel.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] ARM: atmel: sama5d3xek: let gmac auto detect phy id
Date: Mon, 19 Jan 2015 12:39:39 +0100 [thread overview]
Message-ID: <20150119113939.GD30554@ns203013.ovh.net> (raw)
In-Reply-To: <1421661294-23345-1-git-send-email-voice.shen@atmel.com>
On 17:54 Mon 19 Jan , Bo Shen wrote:
> On the SAMA5D33 and SAMA5D35 the GMAC PHY ID is 1 while not 7.
> So, let the GMAC auto detect phy id, or else hard code to 7,
> it can not work on these two boards.
>
> Signed-off-by: Bo Shen <voice.shen@atmel.com>
> ---
>
> arch/arm/boards/sama5d3xek/init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boards/sama5d3xek/init.c b/arch/arm/boards/sama5d3xek/init.c
> index 49d2b37..0b83147 100644
> --- a/arch/arm/boards/sama5d3xek/init.c
> +++ b/arch/arm/boards/sama5d3xek/init.c
> @@ -123,7 +123,7 @@ static void ek_add_device_nand(void) {}
> #if defined(CONFIG_DRIVER_NET_MACB)
> static struct macb_platform_data gmac_pdata = {
> .phy_interface = PHY_INTERFACE_MODE_RGMII,
> - .phy_addr = 7,
> + .phy_addr = -1,
IIRC the auto detect do not work on all board
NACK
Best Regards,
J.
> };
>
> static struct macb_platform_data macb_pdata = {
> --
> 2.3.0.rc0
>
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2015-01-19 11:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-19 9:54 Bo Shen
2015-01-19 11:39 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2015-01-20 0:56 ` Bo Shen
2015-01-21 15:07 ` Sascha Hauer
2015-01-22 4:35 ` Jean-Christophe PLAGNIOL-VILLARD
[not found] ` <54C086AA.9030605@atmel.com>
2015-01-22 6:20 ` Bo Shen
2015-01-22 6:20 ` Bo Shen
2015-01-23 7:36 ` Sascha Hauer
2015-01-23 8:00 ` Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150119113939.GD30554@ns203013.ovh.net \
--to=plagnioj@jcrosoft.com \
--cc=barebox@lists.infradead.org \
--cc=voice.shen@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox