From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YEYns-000385-Hj for barebox@lists.infradead.org; Fri, 23 Jan 2015 07:37:17 +0000 Date: Fri, 23 Jan 2015 08:36:50 +0100 From: Sascha Hauer Message-ID: <20150123073650.GW12209@pengutronix.de> References: <1421661294-23345-1-git-send-email-voice.shen@atmel.com> <20150119113939.GD30554@ns203013.ovh.net> <20150121150729.GK12209@pengutronix.de> <7BD9F41A-FC1D-415B-A3C0-B0555B7B15CA@jcrosoft.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <7BD9F41A-FC1D-415B-A3C0-B0555B7B15CA@jcrosoft.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH] ARM: atmel: sama5d3xek: let gmac auto detect phy id To: Jean-Christophe PLAGNIOL-VILLARD Cc: barebox@lists.infradead.org On Thu, Jan 22, 2015 at 12:35:17PM +0800, Jean-Christophe PLAGNIOL-VILLARD = wrote: > = > > On Jan 21, 2015, at 11:07 PM, Sascha Hauer wro= te: > > = > > On Mon, Jan 19, 2015 at 12:39:39PM +0100, Jean-Christophe PLAGNIOL-VILL= ARD wrote: > >> On 17:54 Mon 19 Jan , Bo Shen wrote: > >>> On the SAMA5D33 and SAMA5D35 the GMAC PHY ID is 1 while not 7. > >>> So, let the GMAC auto detect phy id, or else hard code to 7, > >>> it can not work on these two boards. > >>> = > >>> Signed-off-by: Bo Shen > >>> --- > >>> = > >>> arch/arm/boards/sama5d3xek/init.c | 2 +- > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>> = > >>> diff --git a/arch/arm/boards/sama5d3xek/init.c b/arch/arm/boards/sama= 5d3xek/init.c > >>> index 49d2b37..0b83147 100644 > >>> --- a/arch/arm/boards/sama5d3xek/init.c > >>> +++ b/arch/arm/boards/sama5d3xek/init.c > >>> @@ -123,7 +123,7 @@ static void ek_add_device_nand(void) {} > >>> #if defined(CONFIG_DRIVER_NET_MACB) > >>> static struct macb_platform_data gmac_pdata =3D { > >>> .phy_interface =3D PHY_INTERFACE_MODE_RGMII, > >>> - .phy_addr =3D 7, > >>> + .phy_addr =3D -1, > >> IIRC the auto detect do not work on all board > >> NACK > > = > > Please give us some more information why this doesn't work or on which > > boards this doesn't work. Rejecting patches with 'IIRC' just blocks the > > patch without giving a clue what else should be done. > = > This is the same board but diff=E9rent SoC Module > = > Bo MUST test it on all of them before do such modification > = > IIRC the phy is detect on addr 1 instead of 7 on some CPU Module When the original 7 does not work on all boards, then autodetection seems to be a valid solution. Sascha -- = Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox