From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YEZF2-0003pl-NP for barebox@lists.infradead.org; Fri, 23 Jan 2015 08:05:21 +0000 Date: Fri, 23 Jan 2015 09:04:57 +0100 From: Sascha Hauer Message-ID: <20150123080457.GA12209@pengutronix.de> References: <1421911613-9188-1-git-send-email-voice.shen@atmel.com> <20150123075129.GY12209@pengutronix.de> <81EDBB73-FDD1-48FC-A116-6AD21A073764@jcrosoft.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <81EDBB73-FDD1-48FC-A116-6AD21A073764@jcrosoft.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH] ARM: atmel: sama5d3xek: let emac auto detect phy addr To: Jean-Christophe PLAGNIOL-VILLARD Cc: barebox@lists.infradead.org On Fri, Jan 23, 2015 at 03:53:48PM +0800, Jean-Christophe PLAGNIOL-VILLARD wrote: > > > On Jan 23, 2015, at 3:51 PM, Sascha Hauer wrote: > > > > On Thu, Jan 22, 2015 at 03:26:53PM +0800, Bo Shen wrote: > >> On the SAMA5D35 the EMAC phy addr is 1 while not 0. So, let > >> the EMAC auto detect phy addr, or else hard code to 0, the > >> ethernet can not work on SAMA5D35 board. > >> > >> Signed-off-by: Bo Shen > > > > There ere boards with different phy addresses around, so > > the current state does not work on all boards anyway. So the worst > > thing that can happen with this and the other patch for the gmac is > > that now another set of boards does not work. Let's give it a try. > > I'm open to reports when now some board stops working. > > > > Applied this and the gmac patch. > > except we can auto detect the board we are running from > so it will be better to specify it at Run time > > as we have issue on auto detect on some of them Ok, so your suggestion is to detect the board (type, revision?) and set phy_addr correctly based on this information, right? Fine with me aswell. Is it known which boards have which phy_addr? Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox