From: Sascha Hauer <s.hauer@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] commands/splash: fix '-y' option handling
Date: Mon, 26 Jan 2015 09:16:45 +0100 [thread overview]
Message-ID: <20150126081645.GI12209@pengutronix.de> (raw)
In-Reply-To: <1422192133-17906-1-git-send-email-antonynpavlov@gmail.com>
On Sun, Jan 25, 2015 at 04:22:13PM +0300, Antony Pavlov wrote:
> The '-y' and '-o' options are independent,
> so just add missing 'break'.
>
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
Applied, thanks.
> ---
> commands/splash.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/commands/splash.c b/commands/splash.c
> index 9bd84fb..077c0e4 100644
> --- a/commands/splash.c
> +++ b/commands/splash.c
> @@ -41,6 +41,7 @@ static int do_splash(int argc, char *argv[])
> break;
> case 'y':
> s.y = simple_strtoul(optarg, NULL, 0);
> + break;
> case 'o':
> offscreen = 1;
It is missing here aswell. It's the last case, so this is not currently
a bug, but it could easily turn into a bug once the next option is
added.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2015-01-26 8:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-25 13:22 Antony Pavlov
2015-01-26 8:16 ` Sascha Hauer [this message]
2015-01-26 8:51 ` Jean-Christophe PLAGNIOL-VILLARD
2015-01-26 9:22 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150126081645.GI12209@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox