mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] commands/splash: fix '-y' option handling
Date: Mon, 26 Jan 2015 10:22:37 +0100	[thread overview]
Message-ID: <20150126092237.GL12209@pengutronix.de> (raw)
In-Reply-To: <0085328D-B349-4555-BB8A-7E6EE36D9A96@jcrosoft.com>

On Mon, Jan 26, 2015 at 04:51:14PM +0800, Jean-Christophe PLAGNIOL-VILLARD wrote:
> 
> > On Jan 25, 2015, at 9:22 PM, Antony Pavlov <antonynpavlov@gmail.com> wrote:
> > 
> > The '-y' and '-o' options are independent,
> > so just add missing 'break'.
> > 
> > Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> > ---
> > commands/splash.c | 1 +
> > 1 file changed, 1 insertion(+)
> > 
> > diff --git a/commands/splash.c b/commands/splash.c
> > index 9bd84fb..077c0e4 100644
> > --- a/commands/splash.c
> > +++ b/commands/splash.c
> > @@ -41,6 +41,7 @@ static int do_splash(int argc, char *argv[])
> > 			break;
> > 		case 'y':
> > 			s.y = simple_strtoul(optarg, NULL, 0);
> > +			break;
> > 		case 'o':
> > 			offscreen = 1;
> > 		}
> > -- 
> > 2.1.4
> 
> I already send a patch weeks ago to fix

I can only find this patch from you about splash in the last few months:

[PATCH 2/2] command/splash: fix return value

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2015-01-26  9:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-25 13:22 Antony Pavlov
2015-01-26  8:16 ` Sascha Hauer
2015-01-26  8:51 ` Jean-Christophe PLAGNIOL-VILLARD
2015-01-26  9:22   ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150126092237.GL12209@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=plagnioj@jcrosoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox